logseq-plugin-agenda icon indicating copy to clipboard operation
logseq-plugin-agenda copied to clipboard

fix invalid duration string `DURATION:PT`

Open e-zz opened this issue 11 months ago • 1 comments

fix #293

Check estimatedTime to get the event type correct

e-zz avatar Mar 15 '24 12:03 e-zz

Someone is attempting to deploy a commit to a Personal Account owned by @haydenull on Vercel.

@haydenull first needs to authorize it.

vercel[bot] avatar Mar 15 '24 12:03 vercel[bot]

You can refer to the following code.

import { DEFAULT_ESTIMATED_TIME } from '@/constants/agenda'

  switch (type) {
    case 'multi-days-event':
      // ...
    case 'time-event':
      return {
        ...common,
        duration: { minutes: estimatedTime ?? DEFAULT_ESTIMATED_TIME },
      }
    case 'day-event':
      // ...
  }

haydenull avatar Mar 29 '24 03:03 haydenull

‌‌‌‌Thank you very much for your efforts, and I'm also sorry for taking so long to reply because I have been very busy with work recently.

haydenull avatar Mar 29 '24 03:03 haydenull

‌‌‌‌Thank you very much for your efforts, and I'm also sorry for taking so long to reply because I have been very busy with work recently.

Hi, Thanks for the code review. I have pushed again with the solution you provide. And no worries. I've read your blogs so I understand that you are quite occupied with your work. Make sure to get some rest and come back to the plugin development when you're feeling refreshed! Cheers!

e-zz avatar Mar 29 '24 10:03 e-zz

:tada: This PR is included in version 3.10.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 29 '24 11:03 github-actions[bot]