next-forge icon indicating copy to clipboard operation
next-forge copied to clipboard

Feature: international

Open pedrocarlo opened this issue 1 year ago • 6 comments

Description

Added an I18n package using next-international. I personally like next-international, as it is easy to setup and quite simple to get going. For this package, I mirrored closely how the @repo/auth was built with clerk. I created a middleware, server, and client file to export the necessary functions from next-international, and created a sample folder of with a basic en localization to exemplify how to get started.

Related Issues

#297

Checklist

  • [x] My code follows the code style of this project.
  • [x] I have performed a self-review of my code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have updated the documentation, if necessary.
  • [ ] I have added tests that prove my fix is effective or my feature works.
  • [ ] New and existing tests pass locally with my changes.

Additional Notes

  • Edited the tsconfig for @repo/i18n to "moduleResolution": "bundler" and "module": "ESNext" to support relative imports.
  • Added necessary peerDependencies to circumvent some type errors

pedrocarlo avatar Dec 09 '24 23:12 pedrocarlo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-forge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:36pm
next-forge-app ❌ Failed (Inspect) Dec 9, 2024 11:36pm

vercel[bot] avatar Dec 09 '24 23:12 vercel[bot]

@pedrocarlo is attempting to deploy a commit to the Hayden Bleasel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 09 '24 23:12 vercel[bot]

I have not updated the docs, as I am not quite familiar with writing docs. I would appreciate some help on that. Thanks!

pedrocarlo avatar Dec 09 '24 23:12 pedrocarlo

Any plans to merge it @haydenbleasel ?

yamz8 avatar Dec 22 '24 15:12 yamz8

I think you need to change the package.json name to "@repo/i18n" otherwise this breaks pnpm dev

PierrickLozach avatar Dec 27 '24 16:12 PierrickLozach

Also, I think it would help to have an example?

PierrickLozach avatar Dec 27 '24 16:12 PierrickLozach

Closing in favor of #473 but we may circle back to this implementation soon!

haydenbleasel avatar Mar 05 '25 17:03 haydenbleasel