etab icon indicating copy to clipboard operation
etab copied to clipboard

Add support for all repositories (regardless of code style)

Open ExE-Boss opened this issue 8 years ago • 2 comments

This PR fixes this list of issues I found in the script:

  • Doesn't work license headers and code documentation, which are written like so:
    /**
     * The following object does stuff
     * @type Object
     */
    var obj = {
    	longValueName:	"This string is long",
    	foo:	"foo",
    	bar:	"bar",
    	getBaz	= function getBaz()
    	{
    		return bar;
    	}
    }
    
    This should render as:
    /**
     * The following object does stuff
     * @type Object
     */
    var obj = {
            longValueName: "This string is long",
            foo:           "foo",
            bar:           "bar",
            getBaz         = function getBaz()
            {
                    return bar;
            }
    }
    
    But because of the does line start with a space check in index.js#41, this doesn't happen, because the second line of this file turns elastic tabstops off.
  • Fixes broken tab size: This is done by using the ch unit instead of the em unit
  • Fixes broken tab alignment: This is done by ensuring that the wrapAllTabs() function doesn't try to wrap a tab multiple times.
  • Moves the custom CSS into github.user.css to be loaded by Stylus or Stylish. This makes it an optional feature rather than something that users are forced to use.

ExE-Boss avatar Jun 08 '17 20:06 ExE-Boss

Thank you for the PR. It would be better if you could separate it to multiple PRs for each feature/bugfix.

hax avatar Jul 06 '17 15:07 hax

@hax I have split off this PR into #4, #5 and #6. #4 and #6 are ready to be merged.

ExE-Boss avatar Sep 04 '17 18:09 ExE-Boss