hawkular-apm icon indicating copy to clipboard operation
hawkular-apm copied to clipboard

HWKAPM-817 Add OT agent instrumentation rules for EJB

Open objectiser opened this issue 8 years ago • 3 comments

objectiser avatar Jan 13 '17 11:01 objectiser

@pavolloffay @jpkrohling Could review please?

Notes:

  • This PR includes basic instrumentation rules for demarcating Wildfly/EAP EJB usage. So is not a general EJB instrumentation approach - this could be investigated as a separate jira if there is a need (possibly using some additional class instrumentation outside byteman rules, leveraging the annotations).
  • Currently no tests, as existing agent tests do not rely on a separate server to be launched. Not sure whether it is work adding a specific test for this, or other approach would be to produce an example that includes EJBs, and test it in the instrumentation framework? Has been manually tested currently.

objectiser avatar Jan 13 '17 11:01 objectiser

Agree automated is better, but depends whether we should have a set of tests that depend on a separate server to be launched (not sure how many of the agent rules would require this), or test by example (i.e. create a JEE example that incorporates EJBs, and verify the trace data using the instrumentation-test framework)?

If first option, we then have the choice between arquillian, which we haven't used so far, or just using the wildfly maven plugin?

objectiser avatar Jan 13 '17 12:01 objectiser

If it can be tested with arqullian, it's better than instrumentation-framework I think. At least faster.

pavolloffay avatar Jan 13 '17 12:01 pavolloffay