monaco-editor-uwp icon indicating copy to clipboard operation
monaco-editor-uwp copied to clipboard

Use WebView2

Open jaigak opened this issue 4 years ago • 5 comments

WebView 2 will be available to WinUI 2 soon so consider using that instead of EdgeHTML for better performance.

jaigak avatar Sep 30 '21 06:09 jaigak

That's tied to #56 anyway as part of supporting WinUI 3.

hawkerm avatar Oct 01 '21 06:10 hawkerm

That's tied to #56 anyway as part of supporting WinUI 3.

Right however WinUI 2.8 itself is getting WebView2 so no need of WinUI 3.

jaigak avatar Oct 01 '21 10:10 jaigak

Blocking issue: CoreWebView2.AddHostObjectToScript() results in AV in UWP.

hez2010 avatar Nov 03 '21 06:11 hez2010

@hez2010 is there an issue filed on the WinUI repo for that?

I also hit https://github.com/MicrosoftEdge/WebView2Feedback/issues/75 in general as well which could be challenging to work around, as I'd like new approach to be more direct with some of the Monaco provider objects.

hawkerm avatar Nov 04 '21 02:11 hawkerm

@hez2010 is there an issue filed on the WinUI repo for that?

No, but I reused the issue https://github.com/microsoft/microsoft-ui-xaml/issues/4377.

hez2010 avatar Nov 04 '21 05:11 hez2010