haveno
haveno copied to clipboard
haveno-dex
Account > Wallet Seed view is broken in legacy UI [0.15 XMR]
The Account > Wallet Seed view in the legacy UI is broken.
It's not displaying the mnemonic seed phrase, and the date input boxes grow indefinitely.
There is a bounty on this issue, the amount is in the title. The reward will be awarded to the first person or group of people who resolves this issue.
If you are starting to work on this bounty, please write a comment, so that we can assign the issue to you. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progresses. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.
Read the full conditions and details of our bounty system.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue seems to be linked to macOS javafx-controls-16-mac only as on Linux javafx-controls-16-linux.jar it seems OK.
I was unable to reproduce the mnemonic seed not rendering; although I was able to reproduce and (somewhat) solve the growing date input boxes. Here are the notes I have so far, both regarding the datePicker issue, and some other... oddities I found with the Account Seed View:
P.S. whenever I say "datePicker" I am most likely referring to JFXDatePicker. DatePicker does not have the same issues.
-The issue occurs in both datePicker elements in Seed View. They are the only dataPicker elements currently present in Haveno. -Width isn't modified at instantiation; this means that setting MaxWidth for the element changes nothing except for the starting point of the growth -Growth isn't constrained or influenced by window size -The bug occurs for all UI users regardless of user type (saying this in case the "legacy UI" mentioned in the issue title is implying that this issue only occurs for arbitrators) -For some reason, the growth will become paused when moved from a higher resolution monitor to a lower resolution monitor. In addition, the issue doesn't seem to occur on the lower resolution at all (1080p). The growth continues Most (see next) of the time when moved back to a higher resolution. -Sometimes, when moved from lower to higher resolution quickly, the growth will remain stopped. The growth continues once the window is updated in any way (a button is clicked, a pop-up occurs, etc.) -I could not find a way to reduce or reset the size of the datePicker after growth. Moving to another screen would stop it, but it would continue from the same size once looked at again. Restarting is the only way to (temporarily) return the size back to normal.
-As is described in my PR, I was unable to use a seed to recover a wallet. The button would remain greyed out, even after all information was provided. I was also unable to see the date of the current wallet seed, which would also potentially be part of the issue.
-Using the control buttons to change tabs (Ctrl-{1-8}) from the Account tab to the Account tab again (so Ctrl-8, Ctrl-8) would cause the currently active view to unload entirely
That was what I was able to find looking at it today. I'll send the relevant findings over to JFoenix in regards to JFXDatePicker, although it seems that JFXDatePicker was made in March of 2016, and is still on version 1.0, which could be a sign that a fix isn't coming anytime soon on their end.
Just so we are on the same page as to this issue; this is what I see (pretend the datePickers are JFXDatePickers-the behavior is the same with both)
Should I be able to see a date in the top "Wallet date" field? Is this a bug, or intended/unimplemented behavior?
This behavior is also present when running a full "screen" testnet (1 seednode, 2 monerod, 2 users, and 1 arbitrator), and it also occurs on stagenet.
That behavior isn't implemented yet, so it's expected. I'm looking into it, though it will be nice when the date picker isn't growing :)
Ok, I was thinking that was the case since there wasn’t a usable function to get the date :)
I am unable to reproduce the mnemonic seed not appearing; is this still an issue?
I am unable to reproduce the mnemonic seed not appearing; is this still an issue?
No, the seed appears for me.
I am unable to reproduce the mnemonic seed not appearing; is this still an issue?
No, the seed appears for me.
In that case, is it okay if we treat that part of the issue as resolved unless someone else is still having the issue?
Yes, we can complete this issue and I've opened a separate issue for restoring from seed:
https://github.com/haveno-dex/haveno/issues/752