haveno icon indicating copy to clipboard operation
haveno copied to clipboard

Support restoring an account without restarting havenod [$250]

Open woodser opened this issue 3 years ago • 4 comments

This issue requests the ability to restore an account without restarting havenod.

Otherwise, the client must have permission to start the havenod process, which does not work with remote of vm setups.

woodser avatar May 25 '22 16:05 woodser

There is a bounty on this issue, the amount is in the title. The reward will be awarded to the first person or group of people who resolves this issue.

If you are starting to work on this bounty, please write a comment, so that we can assign the issue to you. We expect contributors to provide a PR in a reasonable time frame or, in case of an extensive work, updates on their progresses. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of our bounty system.

github-actions[bot] avatar May 27 '22 14:05 github-actions[bot]

Hi, I'll give this a try.

duriancrepe avatar May 30 '22 16:05 duriancrepe

I've restructured the code and attempted to restart by running the daemon's execute(args[]) function but there are definitely issues to work through such as the persistence manager assuming its already shutdown. I think this is due to the guice initialized static objects and will need to be re-initialized correctly.

duriancrepe avatar Jun 01 '22 02:06 duriancrepe

Quick update I was able to issue multiple restarts on a daemon instance and it appears to function. It wasn't guice objects but the PersistenceManager static variables. Resetting them appears to solve the problems. Going to search for any remaining static objects that may cause issues.

duriancrepe avatar Jun 04 '22 06:06 duriancrepe

@woodser Is this bug/bounty still open? I can see that #320 has probably been abandoned. I am open to reviving it and driving it to completion.

darkdrag00n avatar Dec 03 '22 17:12 darkdrag00n

Sure you are welcome to complete it, with the bounty being shared with @duriancrepe if he is available to claim it. The split would be somewhat subjective based on his contribution and yours, but it would be nice to close this one out. Thanks.

woodser avatar Dec 03 '22 21:12 woodser

@duriancrepe Please message and we can pay this bounty out. Thanks for your work on it.

woodser avatar Mar 04 '23 17:03 woodser

Closed with:

https://github.com/haveno-dex/haveno/pull/539 https://github.com/haveno-dex/haveno-ts/pull/174

woodser avatar Mar 04 '23 17:03 woodser