haveno
haveno copied to clipboard
Resolve EOF errors on daemon shutdown
This issue requests resolving the errors that appear when shutting down Haveno daemons.
For example:
Feb-02 07:42:36.597 [JavaFX Application Thread] INFO b.n.p2p.network.NetworkNode: Shutdown 4 connections
Feb-02 07:42:36.610 [InputHandler-localhost:2002] WARN b.n.p2p.network.Connection: proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown.
Feb-02 07:42:36.615 [InputHandler-localhost:6666] WARN b.n.p2p.network.Connection: proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown.
Feb-02 07:42:36.616 [InputHandler-localhost:5555] WARN b.n.p2p.network.Connection: proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown.
Feb-02 07:42:36.617 [InputHandler-localhost:5555] WARN b.n.p2p.network.Connection: proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown.
This is from client, no? How is it not legitimate logging error for client to notate that the server/back end is down if so?
This is from client, no? How is it not legitimate logging error for client to notate that the server/back end is down if so?
This is from the backend daemon, printed on shutdown.
If it's expected that the proto stream becomes null on shutdown, then we can check for this condition and avoid or at least the warning, since it's perfectly normal in that circumstance.
The warning is printed here: https://github.com/haveno-dex/haveno/blob/272ae8bfa933ed4ad6b93da7194b57262ea7b3d3/p2p/src/main/java/bisq/network/p2p/network/Connection.java#L790
its already resolved
So you are right, thanks :)