PhysicsMod icon indicating copy to clipboard operation
PhysicsMod copied to clipboard

Physics Mod stops ClientPlayerNetworkEvent.Clone events from firing in Forge

Open neilwightman opened this issue 2 years ago • 3 comments

When adding Physics Mod to a pack, the Forge onRespawn event doesn't get fired into other mods, specifically Death Stats Mod.

To Reproduce

  • Install death stats and physics mod into 1.19.2 Forge instance.
  • Cause the player to die.
  • No event is received in the DeathStats.onRespawn event.

https://legacy.curseforge.com/minecraft/mc-mods/deathstats https://github.com/neilwightman/minecraft-deathstats/tree/1.19.2-forge-dev

This works when disabling the Phsyics Mod.

Minecraft Version: 1.19.2 Physics Mod Version: 2.12.3 Death Stats Version: 1.2.0

image

neilwightman avatar Aug 17 '23 07:08 neilwightman

I am not sure why that happens. The event gets triggered in the ClientPacketListener class' function handleRespawn(ClientboundRespawnPacket p_105066_) but I am not touching that one at all.

haubna avatar Sep 06 '23 12:09 haubna

I was wondering if you have something registered for the onRespawn client event and it maybe throwing an exception stopping others from being called.

neilwightman avatar Sep 07 '23 14:09 neilwightman

I don't use any Forge events.

haubna avatar Sep 11 '23 21:09 haubna