montage icon indicating copy to clipboard operation
montage copied to clipboard

Creating a new round 1 should not bring in duplicate files

Open CiellB opened this issue 1 year ago • 5 comments

Problem: Campaign coordinators sometimes discover an error in their activated round 1. They delete the first round 1 and create a second round 1. Montage then pulls in the same set of images a second time, and with that creates the same tasks a second time, thus doubling up on everything. Jurors then also get double the amount of tasks assigned. The only solution I have currently, is to create a new campaign for them.

Expected behavior: If a file is already in the campaign, Montage should skip adding it a second time. or Montage should also delete the files and tasks originally created when the initial round 1 is deleted. or As campaign creator I could have the rights to reset these settings for the campaign coordinator.

CiellB avatar Oct 10 '24 15:10 CiellB

If I'm understanding correctly, the new round has duplicate images in it? Montage is designed to prevent that: Deleting a round also deactivates the tasks. A new round has a new ID and new tasks. There are several uniqueness constraints in the database to prevent this. I believe this has been done hundreds of times without issue for years now, including in tests.

Please try to reproduce this with a test campaign to see if there's been a regression and link it here. Also link any campaigns where this has occurred That way, I can look at the audit log for more details.

My only guess right now is that this is an occasional misbehavior affecting large rounds, due to timeouts and Toolforge's non-transactional database settings.

mahmoud avatar Oct 10 '24 18:10 mahmoud

Hmm, it has happened a few times over the past years, but not recently (maybe also because now I just create a new campaign.) Let me see if I have time over the weekend or next week to find you some examples.

CiellB avatar Oct 10 '24 19:10 CiellB

The cases where I had to offer a new campaign because of double task creation were explicitly when there were multiple first round created. It does not seem to happen with subsequent rounds.

CiellB avatar Oct 10 '24 19:10 CiellB

This now happened again in Wikimixtura Tarija, https://montage.toolforge.org/#/campaign/912-wikimixtura-tarija The Commons cat (https://commons.wikimedia.org/wiki/Category:Images_from_Wikimixtura_Tarija_2025) has 658 images; quorum is set at 4; pool of tasks should be 2632, but is in fact 5264 tasks big. The jury coordinator comments: "I voted and after 500 it started over again."

CiellB avatar May 25 '25 17:05 CiellB

This might be a new bug, so I created a separate Github issue for it. (coordinator mentions via email: I didn’t stop the round and then create a new one. I just set it once.

CiellB avatar May 26 '25 17:05 CiellB