hatchet icon indicating copy to clipboard operation
hatchet copied to clipboard

docs: worker concurrency not documented correctly (Typescript)

Open semse opened this issue 1 year ago • 3 comments

Documented is:

const worker = hatchet.worker("my-worker", { maxRuns: 5, });

But instead it should be:

const worker = hatchet.worker("my-worker", 5);

The documented code does not work and leads to an error.

https://docs.hatchet.run/home/features/concurrency/overview

semse avatar Jul 25 '24 09:07 semse

I would like to work on this @mavenraven

heysolomon avatar Jul 28 '24 22:07 heysolomon

Hey @heysolomon, @abelanger5 and @grutt are better points of contact.

mavenraven avatar Jul 29 '24 16:07 mavenraven

Thanks for the ping @mavenraven

@semse this change was introduced in https://github.com/hatchet-dev/hatchet-typescript/pull/213 in favor of options, but the change should be backwards compatible with your existing code.

grutt avatar Jul 29 '24 16:07 grutt