bug(engine): data race

[steebchen]

NEW

• [ ]

  ==================
  WARNING: DATA RACE
  Write at 0x00c0008c5bf8 by goroutine 54:
    runtime.racewrite()
        <autogenerated>:1 +0x1e
    github.com/hatchet-dev/hatchet/internal/msgqueue/rabbitmq.(*MessageQueueImpl).subscribe.func2()
        /home/runner/work/hatchet/hatchet/internal/msgqueue/rabbitmq/rabbitmq.go:430 +0xf9
    github.com/hatchet-dev/hatchet/internal/services/controllers/jobs.(*JobsControllerImpl).Start.func2()
        /home/runner/work/hatchet/hatchet/internal/services/controllers/jobs/controller.go:186 +0x5e
    github.com/hatchet-dev/hatchet/cmd/hatchet-engine/engine.Run()
        /home/runner/work/hatchet/hatchet/cmd/hatchet-engine/engine/run.go:319 +0x3bb1
    github.com/hatchet-dev/hatchet/internal/testutils.SetupEngine()
        /home/runner/work/hatchet/hatchet/internal/testutils/setup.go:42 +0x5a4
    github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI.func1()
        /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:58 +0xf0
  
  Previous read at 0x00c0008c5bf8 by goroutine 101:
    runtime.raceread()
        <autogenerated>:1 +0x1e
    github.com/hatchet-dev/hatchet/internal/msgqueue/rabbitmq.(*MessageQueueImpl).subscribe.func1()
        /home/runner/work/hatchet/hatchet/internal/msgqueue/rabbitmq/rabbitmq.go:366 +0x604
  
  Goroutine 54 (running) created at:
    github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI()
        /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:55 +0x33e
    testing.tRunner()
        /opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1595 +0x261
    testing.(*T).Run.func1()
        /opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1648 +0x44
  
  Goroutine 101 (running) created at:
    github.com/hatchet-dev/hatchet/internal/msgqueue/rabbitmq.(*MessageQueueImpl).subscribe()
        /home/runner/work/hatchet/hatchet/internal/msgqueue/rabbitmq/rabbitmq.go:333 +0x34f
    github.com/hatchet-dev/hatchet/internal/msgqueue/rabbitmq.(*MessageQueueImpl).Subscribe()
        /home/runner/work/hatchet/hatchet/internal/msgqueue/rabbitmq/rabbitmq.go:162 +0x16c
    github.com/hatchet-dev/hatchet/internal/services/controllers/jobs.(*JobsControllerImpl).Start()
        /home/runner/work/hatchet/hatchet/internal/services/controllers/jobs/controller.go:176 +0x719
    github.com/hatchet-dev/hatchet/cmd/hatchet-engine/engine.Run()
        /home/runner/work/hatchet/hatchet/cmd/hatchet-engine/engine/run.go:131 +0x1411
    github.com/hatchet-dev/hatchet/internal/testutils.SetupEngine()
        /home/runner/work/hatchet/hatchet/internal/testutils/setup.go:42 +0x5a4
    github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI.func1()
        /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:58 +0xf0
  ==================
  

1. [ ] x

   WARNING: DATA RACE
   Write at 0x00c000500b18 by goroutine 50:
     runtime.racewrite()
         <autogenerated>:1 +0x1e
     github.com/hatchet-dev/hatchet/internal/taskqueue/rabbitmq.(*TaskQueueImpl).subscribe.func2()
         /home/runner/work/hatchet/hatchet/internal/taskqueue/rabbitmq/rabbitmq.go:358 +0x110
     github.com/hatchet-dev/hatchet/internal/services/controllers/jobs.(*JobsControllerImpl).Start.func2()
         /home/runner/work/hatchet/hatchet/internal/services/controllers/jobs/controller.go:169 +0x5e
     github.com/hatchet-dev/hatchet/cmd/hatchet-engine/engine.Run()
         /home/runner/work/hatchet/hatchet/cmd/hatchet-engine/engine/run.go:296 +0x39d1
     github.com/hatchet-dev/hatchet/internal/testutils.SetupEngine()
         /home/runner/work/hatchet/hatchet/internal/testutils/setup.go:42 +0x5a4
     github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI.func1()
         /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:58 +0xf0
   
   Previous read at 0x00c000500b18 by goroutine 98:
     runtime.raceread()
         <autogenerated>:1 +0x1e
     github.com/hatchet-dev/hatchet/internal/taskqueue/rabbitmq.(*TaskQueueImpl).subscribe.func1()
         /home/runner/work/hatchet/hatchet/internal/taskqueue/rabbitmq/rabbitmq.go:328 +0x464
   
   Goroutine 50 (running) created at:
     github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI()
         /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:55 +0x33e
     testing.tRunner()
         /opt/hostedtoolcache/go/1.21.7/x64/src/testing/testing.go:1595 +0x261
     testing.(*T).Run.func1()
         /opt/hostedtoolcache/go/1.21.7/x64/src/testing/testing.go:1648 +0x44
   
   Goroutine 98 (finished) created at:
     github.com/hatchet-dev/hatchet/internal/taskqueue/rabbitmq.(*TaskQueueImpl).subscribe()
         /home/runner/work/hatchet/hatchet/internal/taskqueue/rabbitmq/rabbitmq.go:305 +0x30c
     github.com/hatchet-dev/hatchet/internal/taskqueue/rabbitmq.(*TaskQueueImpl).Subscribe()
         /home/runner/work/hatchet/hatchet/internal/taskqueue/rabbitmq/rabbitmq.go:159 +0x19e
     github.com/hatchet-dev/hatchet/internal/services/controllers/jobs.(*JobsControllerImpl).Start()
         /home/runner/work/hatchet/hatchet/internal/services/controllers/jobs/controller.go:117 +0x8b
     github.com/hatchet-dev/hatchet/cmd/hatchet-engine/engine.Run()
         /home/runner/work/hatchet/hatchet/cmd/hatchet-engine/engine/run.go:109 +0x12cb
     github.com/hatchet-dev/hatchet/internal/testutils.SetupEngine()
         /home/runner/work/hatchet/hatchet/internal/testutils/setup.go:42 +0x5a4
     github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI.func1()
         /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:58 +0xf0
   ==================
   

2. [ ] x

   ==================
   WARNING: DATA RACE
   Write at 0x00c0006b2878 by goroutine 51:
     runtime.racewrite()
         <autogenerated>:1 +0x1e
     github.com/hatchet-dev/hatchet/internal/services/controllers/jobs.(*JobsControllerImpl).Start.func2()
         /home/runner/work/hatchet/hatchet/internal/services/controllers/jobs/controller.go:192 +0x104
     github.com/hatchet-dev/hatchet/cmd/hatchet-engine/engine.Run()
         /home/runner/work/hatchet/hatchet/cmd/hatchet-engine/engine/run.go:300 +0x3b51
     github.com/hatchet-dev/hatchet/internal/testutils.SetupEngine()
         /home/runner/work/hatchet/hatchet/internal/testutils/setup.go:42 +0x5a4
     github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI.func1()
         /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:58 +0xf0
   
   Previous read at 0x00c0006b2878 by goroutine 101:
     runtime.raceread()
         <autogenerated>:1 +0x1e
     github.com/hatchet-dev/hatchet/internal/services/controllers/jobs.(*JobsControllerImpl).Start.func1()
         /home/runner/work/hatchet/hatchet/internal/services/controllers/jobs/controller.go:172 +0x89
   
   Goroutine 51 (running) created at:
     github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI()
         /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:55 +0x33e
     testing.tRunner()
         /opt/hostedtoolcache/go/1.21.7/x64/src/testing/testing.go:1595 +0x261
     testing.(*T).Run.func1()
         /opt/hostedtoolcache/go/1.21.7/x64/src/testing/testing.go:1648 +0x44
   
   Goroutine 101 (running) created at:
     github.com/hatchet-dev/hatchet/internal/services/controllers/jobs.(*JobsControllerImpl).Start()
         /home/runner/work/hatchet/hatchet/internal/services/controllers/jobs/controller.go:170 +0x83c
     github.com/hatchet-dev/hatchet/cmd/hatchet-engine/engine.Run()
         /home/runner/work/hatchet/hatchet/cmd/hatchet-engine/engine/run.go:113 +0x144b
     github.com/hatchet-dev/hatchet/internal/testutils.SetupEngine()
         /home/runner/work/hatchet/hatchet/internal/testutils/setup.go:42 +0x5a4
     github.com/hatchet-dev/hatchet/examples/loadtest/cli.TestLoadCLI.func1()
         /home/runner/work/hatchet/hatchet/examples/loadtest/cli/cli_e2e_test.go:58 +0xf0
   ==================