graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

docs: update clouds screenshots throughout docs

Open akarsh-jain-790 opened this issue 3 years ago • 7 comments
trafficstars

Fixes: #8998

Description

Update all screenshots throughout documentation

Breaking changes

  • [x] No Breaking changes
  • [ ] There are breaking changes:

akarsh-jain-790 avatar Oct 09 '22 09:10 akarsh-jain-790

Beep boop! :robot:

Hey @akarsh-jain-790, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! :sunglasses:

hasura-bot avatar Oct 09 '22 09:10 hasura-bot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
14 out of 22 committers have signed the CLA.

:white_check_mark: hasura-bot
:white_check_mark: abooij
:white_check_mark: Varun-Choudhary
:white_check_mark: abhi40308
:white_check_mark: i-am-tom
:white_check_mark: jberryman
:white_check_mark: lastnamearya
:white_check_mark: soorajshankar
:white_check_mark: wawhal
:white_check_mark: lucarestagno
:white_check_mark: ejkkan
:white_check_mark: seanparkross
:white_check_mark: akarsh-jain-790
:white_check_mark: robertjdominguez
:x: nicoinch
:x: SamirTalwar
:x: dancamma
:x: plcplc
:x: daniel-chambers
:x: danieljharvey
:x: hallettj
:x: soupi
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 09 '22 09:10 CLAassistant

Hi @akarsh-jain-790 👋

Thanks for taking the initiative on this PR! We have a style guide with standards we try to hold across docs; could you take a look and make revisions based on what you find?

Specifically, with these kinds of screenshots, we want to encourage uniformity and anonymity with information. That means removing references to project endpoints, schemas, etc.

Shout with any questions and happy Hacktoberfest 🎃

robertjdominguez avatar Oct 12 '22 19:10 robertjdominguez

@robertjdominguez Have implemented your suggested changes, please let me know if there is anything else I can improve!

akarsh-jain-790 avatar Oct 13 '22 17:10 akarsh-jain-790

Thanks @akarsh-jain-790 🔥

A big piece of our style guide is uniformity in the scale of images, as you can see from this section in our wiki. Could you try again with the listed dimensions (specifically, a width of 1200px)?

robertjdominguez avatar Oct 17 '22 13:10 robertjdominguez

Thanks @akarsh-jain-790 🔥

A big piece of our style guide is uniformity in the scale of images, as you can see from this section in our wiki. Could you try again with the listed dimensions (specifically, a width of 1200px)?

@robertjdominguez I have took the screenshots according to the guideline. Also not all ss can be of 1200px so what should I do in that case?

akarsh-jain-790 avatar Oct 17 '22 14:10 akarsh-jain-790

Also not all ss can be of 1200px so what should I do in that case?

Good question! If a page - for example, the API tab - is too wide to conform to our guidelines, then please seek to come as close as possible to 1200px.

Another example: this screenshot could be significantly smaller to meet our guidelines.

robertjdominguez avatar Oct 17 '22 14:10 robertjdominguez