graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

Updated Screenshots In Docs (close #8883)

Open sujithkdola opened this issue 3 years ago • 3 comments
trafficstars

Description

Updated Screenshots In Databases Section of Docs.

Partially closes #8883

Changelog

Short Changelog

Screenshots updated to 2.10.1 in Databases section of docs.

Long Changelog

updated Screenshots in

databases/connect-db/index databases/postgres/citus-hyperscale-postgres/getting-started/cloud databases/postgres/citus-hyperscale-postgres/getting-started/docker databases/ms-sql-server/getting-started/cloud databases/ms-sql-server/getting-started/docker databases/bigquery/getting-started/docker

Related Issues

Related Issue : #8883

sujithkdola avatar Oct 08 '22 09:10 sujithkdola

Beep boop! :robot:

Hey @Sujithkumardola, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! :sunglasses:

hasura-bot avatar Oct 08 '22 09:10 hasura-bot

Hey @Sujithkumardola Thanks for the PR!

Please could you do a pass and just check the widths for the images you've used. Generally anything which is not a full width screenshot needs to be smaller and ideally the exact same size as the shot. Here for example:

Screenshot 2022-10-13 at 17 21 13

This is too big.

Please let me know and I will do another pass.

Thanks! Sean

seanparkross avatar Oct 13 '22 16:10 seanparkross

Hey @seanparkross I updated the screenshots and you can have a preview here at https://sujith37.vercel.app

If there is any other issue, please let me know.

sujithkdola avatar Oct 15 '22 05:10 sujithkdola

Hey @seanparkross, I made the changes

sujithkdola avatar Oct 19 '22 16:10 sujithkdola

Hey @seanparkross, I made the changes

have a preview here at https://sujith37.vercel.app

sujithkdola avatar Oct 19 '22 16:10 sujithkdola

@Sujithkumardola sorry I hate to be the one to say this but there seems to be a red heart lock on the form fields in some of your shots. I'm not sure if I missed this last time. Sorry if I did. I'm not sure what it is. Maybe a browser extension?

connect-db-cloud-cb5e0b81ade17fcf01a141323732208c

seanparkross avatar Oct 27 '22 12:10 seanparkross

@Sujithkumardola sorry I hate to be the one to say this but there seems to be a red heart lock on the form fields in some of your shots. I'm not sure if I missed this last time. Sorry if I did. I'm not sure what it is. Maybe a browser extension?

connect-db-cloud-cb5e0b81ade17fcf01a141323732208c

As mentioned in the linked issue, I only updated the feature documentation and not the Cloud documentation.

sujithkdola avatar Oct 27 '22 14:10 sujithkdola

@Sujithkumardola sorry I hate to be the one to say this but there seems to be a red heart lock on the form fields in some of your shots. I'm not sure if I missed this last time. Sorry if I did. I'm not sure what it is. Maybe a browser extension?

connect-db-cloud-cb5e0b81ade17fcf01a141323732208c

Could you please specify the file location?

sujithkdola avatar Oct 27 '22 14:10 sujithkdola

Hey! @Sujithkumardola

Thanks so much for your contribution to Hasura OSS during the Hacktoberfest 2022! We'd love to send you some Hasura swag as a token of appreciation and you will be getting an email with the swag form shortly.✨

Stefmore02 avatar Oct 28 '22 20:10 Stefmore02

Beep boop! :robot:

GIF

Awesome work @Sujithkumardola!

Your changes were merged successfully. All of us at Hasura :heart: what you did.

Thanks again :hugs:

hasura-bot avatar Oct 31 '22 11:10 hasura-bot