graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

partial submission for docs:capitalization of headings #8885

Open catcecilia opened this issue 1 year ago • 8 comments

Description

I updated some of the docs to follow the capitalization guideline for the issue referenced below

The reason why I am submitting partial is because I noticed others are interested in doing it too. I want to make sure that no one is overlapping in work.

Changelog

Component : docs

Type: enhancement

Product: community-edition

Short Changelog

Partial docs update regarding capitalization of headings.

Long Changelog

Looked through and updated capitalization of headings in .md and mdx in:

  • graphql-engine/

  • graphql-engine/server

  • graphql-engine/scripts

  • graphql-engine/rfcs

  • graphql-engine/packaging

  • docs/

  • docs/wiki

  • docs/static

  • docs/src

  • docs/scripts

  • docs/public

  • docs/docs/

  • docs/docs/subscriptions

  • docs/docs/security

  • docs/docs/schema

Related Issues

issue #8885

Solution and Design

Partial solution, working together to finish all of docs would be a good suggestion. Also, shouldn't all documentation be updated? Not just the docs directory?

Steps to test and verify

n/a

Limitations, known bugs & workarounds

Limitation is human error

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • [x] No
  • [ ] Yes
    • [ ] Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • [x] No
  • [ ] Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • [ ] Yes
      • [ ] Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • [ ] Yes
      • [ ] Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • [ ] Yes
      • [ ] Not required

GraphQL

  • [x] No new GraphQL schema is generated
  • [ ] New GraphQL schema is being generated:
    • [ ] New types and typenames are correlated

Breaking changes

  • [x] No Breaking changes
  • [ ] There are breaking changes:

catcecilia avatar Oct 05 '22 03:10 catcecilia

Beep boop! :robot:

Hey @catcecilia, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! :sunglasses:

hasura-bot avatar Oct 05 '22 03:10 hasura-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 05 '22 03:10 CLAassistant

Hey @catcecilia Just curious as to why you closed this? Looked like a great PR...?

seanparkross avatar Oct 07 '22 13:10 seanparkross

I closed it because there was another naming convention issue which I hadn't taken account to posted under ( correct capitalization for hasura features #8884 )

I do not want to undo anyone's work so I'll be relooking at everything I've done over the weekend to make sure I did not made any incorrect lower cases in headings

catcecilia avatar Oct 07 '22 13:10 catcecilia

Hi @catcecilia actually the other PR needs a lot of work because it was done with script which needs to take into account a lot of edge cases. Your PR would be a much better starting point actually. If you want to reopen and ping me I will review it. Yes?

seanparkross avatar Oct 11 '22 17:10 seanparkross

Okay sounds good! I will go ahead and reopen it.

catcecilia avatar Oct 11 '22 17:10 catcecilia

Hi Cat. The PR is looking good. Please could you just revert changes to anything outside the docs directory... eg:

Screenshot_2022-10-18_at_15_50_27

seanparkross avatar Oct 18 '22 14:10 seanparkross

Hi there, just did it. Thank you for your patience. I was figuring out how to use GitHub still when I edited directly vs editing on Github Desktop.

catcecilia avatar Oct 18 '22 17:10 catcecilia

Hey! @catcecilia

We truly appreciate your contribution to Hasura OSS during Hacktoberfest 2022! We'd love to send you some Hasura swag as a token of appreciation. Could you please send me an email to [email protected] with a reference of this PR so I can send you the swag form? ✨

Stefmore02 avatar Oct 27 '22 15:10 Stefmore02

@catcecilia I just merged master back because there were conflicts.

Please can you click and accept the CLA agreement in the message above before we're able to merge.

Thanks

seanparkross avatar Oct 28 '22 13:10 seanparkross

@seanparkross done. my apologies on not agreeing to it sooner!

catcecilia avatar Oct 28 '22 15:10 catcecilia

Beep boop! :robot:

GIF

Awesome work @catcecilia!

Your changes were merged successfully. All of us at Hasura :heart: what you did.

Thanks again :hugs:

hasura-bot avatar Oct 28 '22 17:10 hasura-bot