graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

Update Digital Ocean docs with caddy bug fix info

Open tehpsalmist opened this issue 1 year ago • 6 comments

Description

https://caddy.community/t/way-to-cache-ssl-certificate-and-not-reissue-it-every-reload-docker/10385

This issue crops up if you reload the docker-compose file too often. This PR inserts a step in the docs to clarify how to avoid that issue.

Changelog

Component : docs

Type: bugfix

Product: community-edition

Short Changelog

inserts a step in the Digital Ocean guide for enabling SSL via Caddy.

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • [x] No
  • [ ] Yes
    • [ ] Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • [x] No
  • [ ] Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • [ ] Yes
      • [ ] Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • [ ] Yes
      • [ ] Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • [ ] Yes
      • [ ] Not required

GraphQL

  • [x] No new GraphQL schema is generated
  • [ ] New GraphQL schema is being generated:
    • [ ] New types and typenames are correlated

Breaking changes

  • [x] No Breaking changes
  • [ ] There are breaking changes:

tehpsalmist avatar Sep 07 '22 20:09 tehpsalmist

Beep boop! :robot:

Hey @tehpsalmist, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! :sunglasses:

hasura-bot avatar Sep 07 '22 20:09 hasura-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 07 '22 20:09 CLAassistant

Thanks for this PR, @tehpsalmist 🚀

Taking a look at this and getting back to you soon 👍

robertjdominguez avatar Sep 08 '22 15:09 robertjdominguez

Thanks for this PR, @tehpsalmist 🚀

Taking a look at this and getting back to you soon 👍

If you need any insight from me while reviewing, I'm available any time: [email protected]

tehpsalmist avatar Sep 12 '22 22:09 tehpsalmist

Hi @tehpsalmist, the volumes are only removed if you use -v in docker compose down command, right? Why do we need to explicitly create the volume then? Let me know if I am missing something.

shahidhk avatar Sep 16 '22 17:09 shahidhk

do we need to explicitly create the volume then?

Admittedly, I don't know enough about docker to say that this is an exclusively required step, but I do know that the existing commands and configurations given led to the volume being destroyed every time down/up was run. If you know how to configure the docker compose file so that the volume will persist without manually creating it, then that would also solve the problem. Then we can update the repo that holds the Digital Ocean configuration with that change.

tehpsalmist avatar Sep 16 '22 17:09 tehpsalmist