graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

Add X-Forwarded-Origin header

Open kraftwerk28 opened this issue 1 year ago • 2 comments

Description

Most of reverse proxies forward client Origin header as X-Forwarded-Origin. However, Hasura (as a proxy between client and Actions backend) doesn't

Changelog

  • [ ] CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • [x] Server
  • [ ] Console
  • [ ] CLI
  • [ ] Docs
  • [ ] Community Content
  • [ ] Build System
  • [ ] Tests
  • [ ] Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • [x] No
  • [ ] Yes
    • [ ] Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • [x] No
  • [ ] Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • [ ] Yes
      • [ ] Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • [ ] Yes
      • [ ] Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • [ ] Yes
      • [ ] Not required

GraphQL

  • [x] No new GraphQL schema is generated
  • [ ] New GraphQL schema is being generated:
    • [ ] New types and typenames are correlated

Breaking changes

  • [x] No Breaking changes

  • [ ] There are breaking changes:

    1. Metadata API

      Existing query types:

      • [ ] Modify args payload which is not backward compatible
      • [ ] Behavioural change of the API
      • [ ] Change in response JSON schema
      • [ ] Change in error code
    2. GraphQL API

      Schema Generation:

      • [ ] Change in any NamedType
      • [ ] Change in table field names

      Schema Resolve:-

      • [ ] Change in treatment of null value for any input fields
    3. Logging

      • [ ] Log JSON schema has changed
      • [ ] Log type names have changed

kraftwerk28 avatar Jul 29 '22 08:07 kraftwerk28

Beep boop! :robot:

Hey @kraftwerk28, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! :sunglasses:

hasura-bot avatar Jul 29 '22 08:07 hasura-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 29 '22 08:07 CLAassistant

@praveenweb could you approve pls?

nosovk avatar Sep 06 '22 12:09 nosovk

@kraftwerk28 This PR looks good to me, so I'm approving it and it should be merged shortly. Thank you for your contribution!

sassela avatar Sep 19 '22 14:09 sassela

Beep boop! :robot:

GIF

Awesome work @kraftwerk28!

Your changes were merged successfully. All of us at Hasura :heart: what you did.

Thanks again :hugs:

hasura-bot avatar Sep 19 '22 14:09 hasura-bot