graphql-engine
graphql-engine copied to clipboard
Add X-Forwarded-Origin header
Description
Most of reverse proxies forward client Origin header as X-Forwarded-Origin. However, Hasura (as a proxy between client and Actions backend) doesn't
Changelog
- [ ]
CHANGELOG.md
is updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-required
label.
Affected components
- [x] Server
- [ ] Console
- [ ] CLI
- [ ] Docs
- [ ] Community Content
- [ ] Build System
- [ ] Tests
- [ ] Other (list it)
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
- [x] No
- [ ] Yes
- [ ] Updated docs with SQL for downgrading the catalog
Metadata
Does this PR add a new Metadata feature?
- [x] No
- [ ] Yes
- Does
run_sql
auto manages the new metadata through schema diffing?- [ ] Yes
- [ ] Not required
- Does
run_sql
auto manages the definitions of metadata on renaming?- [ ] Yes
- [ ] Not required
- Does
export_metadata
/replace_metadata
supports the new metadata added?- [ ] Yes
- [ ] Not required
- Does
GraphQL
- [x] No new GraphQL schema is generated
- [ ] New GraphQL schema is being generated:
- [ ] New types and typenames are correlated
Breaking changes
-
[x] No Breaking changes
-
[ ] There are breaking changes:
-
Metadata API
Existing
query
types:- [ ] Modify
args
payload which is not backward compatible - [ ] Behavioural change of the API
- [ ] Change in response
JSON
schema - [ ] Change in error code
- [ ] Modify
-
GraphQL API
Schema Generation:
- [ ] Change in any
NamedType
- [ ] Change in table field names
Schema Resolve:-
- [ ] Change in treatment of
null
value for any input fields
- [ ] Change in any
-
Logging
- [ ] Log
JSON
schema has changed - [ ] Log
type
names have changed
- [ ] Log
-
Beep boop! :robot:
Hey @kraftwerk28, thanks for your PR!
One of my human friends will review this PR and get back to you as soon as possible.
Stay awesome! :sunglasses:
@praveenweb could you approve pls?
@kraftwerk28 This PR looks good to me, so I'm approving it and it should be merged shortly. Thank you for your contribution!
Beep boop! :robot:
Awesome work @kraftwerk28!
Your changes were merged successfully. All of us at Hasura :heart: what you did.
Thanks again :hugs: