graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

Some of the Hasura console page's style is broken.

Open PJijin opened this issue 3 years ago • 4 comments

Version Information

Hasura version: v2.8.4

How to reproduce the issue?

  1. Go to data -> select any table -> click on edit (the label is not shown there. check the screenshot below.)
  2. Click on events -> click on any event -> click on the edit option at Trigger operations
  3. Click on events -> any event -> click on invocation logs -> click on retry

Screenshots or Screencast

image image image

PJijin avatar Jul 13 '22 09:07 PJijin

Working on this.

sudeshna-22 avatar Jul 15 '22 07:07 sudeshna-22

Hey Folks,

Thanks for reporting the issue @PJijin!

Thanks for volunteering to contribute @sudeshna-22! I'm assigning this issue to you. Here are some suggestions from our end,

  • We started using more TailwindCSS and less CSS/SCSS to simplify the UI development, would appreciate if you can follow the pattern.
  • Here is a storybook document that explains our latest tooling.

Please reach out to us if you have any doubts, Happy to help :)

soorajshankar avatar Jul 18 '22 13:07 soorajshankar

A recent commit to the main repo appears to have resolved the problems raised in this issue. However, there are some section that could be improved.

  1. There is some change in the edit section of the data which does not match other view of the application.
  2. There is no space between the button and other elements.

I believe I can improve this section.

image

sudeshna-22 avatar Jul 20 '22 10:07 sudeshna-22

Will be solving this in this issue: The styling of the data table view and edit row sections needs an improvement. #8704

sudeshna-22 avatar Jul 20 '22 11:07 sudeshna-22

Closing in favour of #8704

seanparkross avatar Aug 25 '22 12:08 seanparkross