graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

Published 20 hours ago • verified publisher icon hasura

Type currently unsupported for BigQuery: StructScalarType

Open mvanlonden opened this issue 2 years ago • 3 comments

Wondering why the StructScalarType is not supported in the Google BigQuery integration. Looks like the type was never implemented in the schema file. https://github.com/hasura/graphql-engine/blob/3db241155dcd22dca9f5164ec6051ef0dd05550a/server/src-lib/Hasura/Backends/BigQuery/Instances/Schema.hs#L157-L180.

I'd like to attempt adding support for this type. @chrisdone @nicuveo @psibi @aniketd @0x777 do you why this field wasn't originally included in the initial BigQuery PR https://github.com/hasura/graphql-engine/commit/f7a202a363dce69c3980b7bb57cbd5c07e258a1c? Is there some limitation that I will encounter when trying to implement?

mvanlonden avatar May 11 '22 04:05 mvanlonden

@mvanlonden The implementation was skipped to contain the scope of work. There wan't any particular technical hurdle.

aniketd avatar May 13 '22 04:05 aniketd

Thank you

mvanlonden avatar May 13 '22 23:05 mvanlonden

Does this happen to be in any upcoming plans? Would be cool to have! :)

silky avatar Oct 17 '22 11:10 silky

Hi aniketd, Any near-future plans to add the structscalar support for bigquery. It would be very useful

harikarajavaram avatar Jan 25 '23 15:01 harikarajavaram

Hi aniketd, @chrisdone @silky @nicuveo @psibi Could you please enable feature of mvanlonden to support structscalar types in bigquery. Thanks

lungade avatar Jan 25 '23 15:01 lungade

@0x777 would be the right person to look into this.

aniketd avatar Sep 07 '23 05:09 aniketd