graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

community: add Gujrati translation for code of conduct (fixes #5851)

Open shloka-gupta opened this issue 5 years ago • 12 comments
trafficstars

Description

Add Bengali translation for code-of-conduct.md file

Changelog

CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components Docs

Related Issues

fix #5851

Catalog upgrade

Does this PR change Hasura Catalog version? No

Does this PR add a new Metadata feature? No

GraphQL

No new GraphQL schema is generated

Breaking changes

No Breaking changes

shloka-gupta avatar Oct 03 '20 15:10 shloka-gupta

Beep boop! :robot:

Hey @chicken-biryani, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! :sunglasses:

hasura-bot avatar Oct 03 '20 15:10 hasura-bot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 03 '20 15:10 CLAassistant

Description

Add Gujrati translation for code-of-conduct.md file

Changelog

CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components Docs

Related Issues

fix #5851

Catalog upgrade

Does this PR change Hasura Catalog version? No

Does this PR add a new Metadata feature? No

GraphQL

No new GraphQL schema is generated

Breaking changes

No Breaking changes

shloka-gupta avatar Oct 03 '20 16:10 shloka-gupta

@chicken-biryani, The files are in PDF. Could you please change them to Markdown? The extension of the should be .md instead of .pdf

Naveenaidu avatar Oct 03 '20 16:10 Naveenaidu

Alright. Can i add more translations tho

shloka-gupta avatar Oct 03 '20 16:10 shloka-gupta

@Naveenaidu where am i going wrong? can u please help me out?

shloka-gupta avatar Oct 03 '20 18:10 shloka-gupta

@chicken-biryani Thank you very much for taking the time to translate our documentation. We really appreciate your help.

There are few things that you might've to learn and change and then this PR would fly like a rocket :rocket:

  1. Please spend some time to learn about the formatting of Markdown. You can use this website to learn about them. That will help you understand why your file is not properly formed and you'll be able to make the changes. But don't be scared, if you still need help after reading the tutorial we will be more than happy to help you out.

  2. You also need to make a change to the Translation section of the Code of Conduct and mention your translated file. To make this possible, you will have to edit the Code of Conduct file and add the following line in the Translation section

- [Hindi :india:](translations/code-of-conduct.gujrati.md)
  1. Just a minor nitpick, but you don't have to comment the, Description of changes you make, each time you push. That means comments like these are not necessary :)

Hope this helps ^ ^

Naveenaidu avatar Oct 04 '20 13:10 Naveenaidu

Apologies for spamming. I thought I had to make a change in the comment everytime. I'll take a look at whatsup with my PR

shloka-gupta avatar Oct 04 '20 16:10 shloka-gupta

Deploy preview for hasura-docs ready!

Built with commit 4584d62bf3a63cd75374b9b347f6f783f38b0e8d

https://deploy-preview-5898--hasura-docs.netlify.app

netlify[bot] avatar Oct 05 '20 10:10 netlify[bot]

@Naveenaidu so thank you for the link. I realized my mistakes :') . I made the changes and.. there's just one part that's going wrong. So ya! I am still confused. (I am sorry for all the trouble)

shloka-gupta avatar Oct 05 '20 10:10 shloka-gupta

@chicken-biryani Please use https://raw.githubusercontent.com/hasura/graphql-engine/master/code-of-conduct.md as a reference to understand what's going wrong.

There are some minor markdown formatting issues. This should help you fix them.

You can use something like: https://stackedit.io/app# to see how the markdown is rendered as you make changes :)

Naveenaidu avatar Oct 05 '20 11:10 Naveenaidu

@Naveenaidu ..... I went through it and I think the build is failing because there is no no-changelog-required label. Can you please add it?

shloka-gupta avatar Oct 08 '20 17:10 shloka-gupta