graphql-engine
graphql-engine copied to clipboard
console: add ErrorBoundary for VoyagerView and fix memory requirements of viz.js (close #4818)
Changelog
- [x]
CHANGELOG.md
is updated with user-facing content relevant to this PR.
Affected components
- [x] Console
Related Issues
#3023, should fix #4818
Solution and Design
The design is the same as the RuntimeError
component, as suggested in #4818 one of the solutions is an Error Boundary specifically for the VoyagerView
component. Which, now, has been implemented.
~~[x] Next would be to try and get to the root of the problem on the VoyagerView
~~
The main problem being that for larger schema's and tables, the visualizer runs out of memory on the stack and so we had to rectify that by increasing the stack memory and buffer memory that is allocated to viz.js
for rendering the graph
Steps to test and verify (to be changed)
- ~~First make 40+ tables on the
GraphQL console
~~ - ~~You should see the fallback mentioned in the
VoyagerErrBoundary
component if an error does occur. ~~
Error screen
Beep boop! :robot:
Hey @kolharsam, thanks for your PR!
One of my human friends will review this PR and get back to you as soon as possible.
Stay awesome! :sunglasses:
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
:white_check_mark: soorajshankar
:white_check_mark: kolharsam
:x: Sameer Kolhar
Sameer Kolhar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Deploy preview for hasura-docs ready!
Built with commit 4a853743a6e148fb6da014a6e97f8ba44e310d17
https://deploy-preview-4856--hasura-docs.netlify.app
Review app for commit bc66ec408e921b2921142d950f46560ad33a7668 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-bc66ec40
Review app for commit d56f82027f5ca64410c2ff96fddf091d9ddd6a0f deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-d56f8202
Review app for commit 63da193b5d4c5eb3d143f179a45607ca1c87a42b deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-63da193b
Review app for commit f32b0dc6fb03b466cf025467bb0c0a5f07a80184 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-f32b0dc6
Review app for commit 1a6ad2ef381b805f242513d28ff3a156989b7cfe deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-1a6ad2ef
Review app for commit 62e9c6dc6635021159cb19ba0b22ed01c5cbed29 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-62e9c6dc
Review app for commit c3101ed20263c103ccc6d10d3729847a75661a52 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-c3101ed2
Review app for commit e632dd8d79c67d4837908a4349f0b6cca1de7a67 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-e632dd8d
Review app for commit f932451ba93dfdf2da3b9206a350e32a08eaa5d8 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-f932451b
Review app for commit 4fb04cf733ee045327242614e6dd967db1de1408 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-4fb04cf7
@kolharsam Please fix the conflicts
Also, can we make ErrorBoundaryComponent more generic? maybe by passing the title and description as props and renaming the component with a generic name. I see that currently, we use this only for voyager view but maybe we can use this somewhere else in the future
Review app for commit c68f6cd847ed63ebb3361abf42a5eafb9c186413 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-c68f6cd8
Review app for commit f456ff21f5581ab2dcd10fa8b42019f21981c615 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-f456ff21
Review app for commit a02dce3d26fc4e68f41be95ffe904853b3f8ea85 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-a02dce3d
Review app for commit 6a5698cee51a1591980d149197708e4516557148 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-6a5698ce
Review app for commit 25eba425b5cf91a2e6cf39966dbab5bf19480388 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-25eba425
Review app for commit f61a73e73438c08bda6908377dee0a1c842d9b69 deployed to Heroku: https://hge-ci-pull-4856.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4856-f61a73e7