graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

How to limit rows per query for admin.

Open michael-land opened this issue 5 years ago • 6 comments

Is there anyway to set limit number of rows for the default admin row?

michael-land avatar Dec 03 '19 21:12 michael-land

@xiaoyu-tamu It is currently not possible to limit the number of rows returned for the admin role. the admin role is designed to have full access to the system.

Can you explain your use case for this requirement in some more detail.

rikinsk avatar Dec 12 '19 08:12 rikinsk

@rikinsk Yes, Sometimes we execute query in GRAPHIQL without limit parameter accidentally (it happens quite often if people use ctrl + enter to execute query). The query takes long time and may cause browser to crash since it try to render 10 million rows.

michael-land avatar Dec 12 '19 14:12 michael-land

Maybe we can add a frontend control flow. That control runs when a query wanted to run without the limit parameter. Just asks the user: are you sure run to this command?

delirehberi avatar Apr 11 '20 12:04 delirehberi

@lexi-lambda What's the decision on how to handle this ? Is it going to be just an alert in the browser like @delirehberi I'm asking as it's labelled under c/server and not under c/console. I'd like to pick it up either ways. Thanks

akshay5995 avatar May 06 '20 13:05 akshay5995

@Stefmore02 Can I have a stab at this? If all goes well, I'll probably have a PR in 2 - 3 weeks

Benjamin-Philip avatar Oct 06 '22 13:10 Benjamin-Philip

@Benjamin-Philip go right ahead! Deadline: For your PR to qualify for Hacktoberfest, you must submit it on or before October 31st. The PR that is submitted first will also be the one to be reviewed first 🙂

Stefmore02 avatar Oct 06 '22 14:10 Stefmore02

If no one is working on it could I get this assigned and if possible point me to a starting point

sachsom95 avatar Mar 22 '23 22:03 sachsom95

@sachsom95 you got this assigned or are you working on it?

palash018 avatar May 26 '23 06:05 palash018

@sachsom95 you got this assigned or are you working on it?

yet to get assigned @palash018

sachsom95 avatar May 31 '23 08:05 sachsom95

if you get this assigned would you like to work together

palash018 avatar Jun 02 '23 15:06 palash018

Hey folks @sachsom95 @palash018 we don't assign issues/PRs so feel free to start working on it. Once your PR is submitted, we'll review it (first come, first served).

Stefmore02 avatar Jun 05 '23 13:06 Stefmore02