graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

Multi-tab UI for GraphiQL to keep queries

Open revskill10 opened this issue 5 years ago • 15 comments

Currently with graphql-playground, you can have multi-tab UI , so we don't have to delete/recreate queries we want to keep them there. There're two options for this.

  • Adopt graphql-playground or something similar for a better UX.
  • Hacking on GraphiQL.

revskill10 avatar Aug 30 '18 19:08 revskill10

@praveenweb @revskill10 Cant't the History button and the sidebar on GraphiQL itself serve this purpose?

shahidhk avatar Sep 05 '18 16:09 shahidhk

@shahidhk I think in long term, multi-tab is unavoidable when you have large number of queries to test at the same time, so it would be easier to manage through tabs.

revskill10 avatar Sep 06 '18 05:09 revskill10

I think adopting graphql-playground is a better choice because we can have multiple tabs which allow us to do multiple queries at a time. For example, We can test subscriptions with playground by subscribing in one tab and doing mutations in other. I don't know if this can be achieved with the history feature of GraphiQL.

JeetChaudhari avatar Dec 17 '18 12:12 JeetChaudhari

I think GraphiQL in the Hasura console is enough.

If you want to use the GraphiQL Playground, which is a great tool, you can use it separately as a web app without adopt it into the Hasura console.

elitan avatar Jan 22 '19 07:01 elitan

I would suggest adopting Altair though.

imolorhe avatar Feb 04 '19 20:02 imolorhe

Wooooo @imolorhe it's very beautiful. Thanks

mnlbox avatar Feb 06 '19 06:02 mnlbox

I believe it should be a short-term feature It's really annoying when working on a real project and you can not manage all the queries in the console I have to copy and paste from the code every time

Compared with apollo studio and Altair, GrqphiQl interface is outdated

And as the issue is open since 2018, its supposed to be fixed by now even with the long term label

abdifardin avatar Jul 19 '22 07:07 abdifardin

@FakhruddinAbdi Hasura is open source. If you want this fixed, you can do so and make a PR.

elitan avatar Jul 19 '22 13:07 elitan

You can try with a plugin like:

https://www.apollographql.com/docs/devtools/editor-plugins/

So you won't need to copy and paste the queries all the time.

Celvin Rivas https://celvinrivas.com +(503) 7126 9172

On Tue, Jul 19, 2022 at 7:37 AM Johan Eliasson @.***> wrote:

@FakhruddinAbdi https://github.com/FakhruddinAbdi Hasura is open source. If you want this fixed, you can do so and make a PR.

— Reply to this email directly, view it on GitHub https://github.com/hasura/graphql-engine/issues/336#issuecomment-1189065358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMP3JVWZCWO3Z7IPACZ4DVU2VSHANCNFSM4FSQPYHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

celvin avatar Jul 19 '22 16:07 celvin

You can try with a plugin like: https://www.apollographql.com/docs/devtools/editor-plugins/ So you won't need to copy and paste the queries all the time. Celvin Rivas https://celvinrivas.com +(503) 7126 9172 On Tue, Jul 19, 2022 at 7:37 AM Johan Eliasson @.> wrote: @FakhruddinAbdi https://github.com/FakhruddinAbdi Hasura is open source. If you want this fixed, you can do so and make a PR. — Reply to this email directly, view it on GitHub <#336 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMP3JVWZCWO3Z7IPACZ4DVU2VSHANCNFSM4FSQPYHA . You are receiving this because you are subscribed to this thread.Message ID: @.>

I'm not sure what you mean, because the plugin is all about syntax highlighting and auto-complete features, Nothing more

abdifardin avatar Jul 19 '22 17:07 abdifardin

@FakhruddinAbdi Hasura is open source. If you want this fixed, you can do so and make a PR.

you are partially correct. but is not a minor bug fixing and the main project is not fully open source.

abdifardin avatar Jul 19 '22 17:07 abdifardin

I think I'm 100% correct because:

  • Whether a bug (it's not really a bug but a feature request) is minor or major is arbitrary.
  • The part you want to be fixed is open source.

elitan avatar Jul 20 '22 07:07 elitan

@elitan Your point is not wrong, but it's not helpful, because we're on github, and of course Hasura Core is open source. So the quote "Because it's open source, if you want to have a feature, please make a PR for it" seems unrelated, as it's 100% correct, regardless of any kind of github open source project. So what's the point of commenting such thing here ?

Feature request is to let the team know of real demand from users.

Hope Hasura team could hide your message because of not related purpose. Or you can just copy and paste your message to all feature request GH issues here.

revskill10 avatar Jul 21 '22 11:07 revskill10

Adding useful comments to expand issues and show user demand is good.

What's not helpful, and what I was pointing out, is this type of comment:

And as the issue is open since 2018, its supposed to be fixed by now

https://github.com/hasura/graphql-engine/issues/336#issuecomment-1188724170

elitan avatar Jul 21 '22 11:07 elitan

@elitan I could interpret that sentence as: I desperately need this feature. What's wrong about it ? The point is the comment "It's open source, so you need to open a PR to ask for PR request" is not related at all.

revskill10 avatar Jul 21 '22 12:07 revskill10

This request is already addressed in the new Hasura V3, hence closing this. The Hasura V3 console supports the latest GraphiQL which has the multiple tab support. Please follow the guide here for Alpha access to Hasura V3.

manasag avatar Dec 27 '23 09:12 manasag