graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

server: fix action sync websocket test

Open emmanuel-ferdman opened this issue 7 months ago • 3 comments

Description

Resolved duplicate test function names in the websocket action test suite by renaming conflicting test cases to maintain clear distinction between success and failure scenarios.

Changelog

Component: server
Type: bugfix
Product: community-edition

Short Changelog

Fixed test naming conflicts in action test suite.

Long Changelog

  • Identified and resolved duplicate test function names
  • Ensured proper naming conventions for success/failure test variants
  • Maintained existing test coverage while improving test clarity

Related Issues

Solution and Design

  • Analyzed test suite for naming conflicts
  • Applied consistent naming pattern to distinguish test cases
  • Verified no impact on test functionality

Steps to test and verify

  1. Execute the full test suite
  2. Verify all test cases run independently
  3. Confirm test output shows proper case differentiation

Limitations, known bugs & workarounds

None - this change only affects test naming.

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • [x] No

Metadata

Does this PR add a new Metadata feature?

  • [x] No

GraphQL

  • [x] No new GraphQL schema is generated

Breaking changes

  • [x] No Breaking changes

emmanuel-ferdman avatar May 11 '25 15:05 emmanuel-ferdman

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 11 '25 15:05 CLAassistant

Thanks for raising this pull request @emmanuel-ferdman! 🙏 Appreciate you taking the time to clean up the test naming conflicts in the websocket action test suite. Having a clear distinction between success and failure scenarios definitely improves test readability and maintainability. We'll review the changes and test the behavior soon. Thanks for the detailed description and changelog - they make the review process much smoother. We'll get back to you once we've completed our testing and review!

Varun-Choudhary avatar Jun 10 '25 04:06 Varun-Choudhary

Thanks for noticing this, and sorry it fell through the cracks! This has been merged

jberryman avatar Sep 11 '25 13:09 jberryman