graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

fix #10640: the interface fails to be queried,/v1/graphql

Open david-ourlegup opened this issue 9 months ago • 2 comments

The schema registry notification color hook has been updated to improve performance. A check was added to skip API calls if running in CE mode or if the schema registry host is not configured. This change also includes a modification that skips the query completely when the schema registry is unavailable, and returns a loading state instead. These enhancements aim to optimize resource usage and provide better user experience.

david-ourlegup avatar Mar 14 '25 08:03 david-ourlegup

Thanks @david-ourlegup for submitting this PR to improve the schema registry notification color hook! These optimizations look very useful - particularly skipping API calls in CE mode and when the schema registry host isn't configured, and the improved handling when the registry is unavailable. We'll test these changes and review the code. If everything looks good, we'll merge this and include it in our next release. Appreciate your contribution to improving performance and UX!

Varun-Choudhary avatar Mar 20 '25 12:03 Varun-Choudhary

Thanks again @david-ourlegup for your PR contribution. To help me better understand the changes:

Could you please elaborate on what specific problem you encountered that led to these optimizations? I'd like to understand the exact issue you're trying to solve. If possible, could you share a screen recording that demonstrates the issue and how your changes address it? This would be very helpful for my review process.

Your insights will help ensure we properly test and validate the improvements before merging. Looking forward to your response!

Varun-Choudhary avatar Mar 20 '25 12:03 Varun-Choudhary