graphql-engine icon indicating copy to clipboard operation
graphql-engine copied to clipboard

Fix/event trigger UI refinements

Open ullasgowda opened this issue 6 months ago • 1 comments

Description

This PR provides fix for issue https://github.com/hasura/graphql-engine/issues/10080 Fix minor UI related issues in Event Triggers - Header Section.

Changelog

Component : console

Type: bugfix

Product: community-edition

Short Changelog

  • increase the width for header-edit section, to properly allow the inputs to occupy the avilable width
  • add medium level z-index over header value-type dropdown options, so it renders over the othere input attributes.
  • use similar padding for table-row-data with respect to the table-row-header for table which shows existing headers for event triggers

Long Changelog

Related Issues

Solution and Design

  • Increase width for header editor and input attribute before: image

after: image

  • Add same padding to table-data with respect to table-header before: image

after: image

  • z-index for dropdown options before: image

after: image

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • [x] No
  • [] Yes
    • [] Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • [x] No
  • [] Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • [] Yes
      • [] Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • [] Yes
      • [] Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • [] Yes
      • [] Not required

GraphQL

  • [x] No new GraphQL schema is generated
  • [] New GraphQL schema is being generated:
    • [] New types and typenames are correlated

Breaking changes

  • [x] No Breaking changes

  • [] There are breaking changes:

    1. Metadata API

      Existing query types:

      • [] Modify args payload which is not backward compatible
      • [] Behavioural change of the API
      • [] Change in response JSON schema
      • [] Change in error code
    2. GraphQL API

      Schema Generation:

      • [] Change in any NamedType
      • [] Change in table field names

      Schema Resolve:-

      • [] Change in treatment of null value for any input fields
    3. Logging

      • [] Log JSON schema has changed
      • [] Log type names have changed

ullasgowda avatar Jan 04 '24 17:01 ullasgowda

Beep boop! :robot:

Hey @ullasgowda, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! :sunglasses:

hasura-bot avatar Jan 04 '24 17:01 hasura-bot