hastic-server icon indicating copy to clipboard operation
hastic-server copied to clipboard

some analytics_service refactoring

Open jonyrock opened this issue 5 years ago • 0 comments

I thing we should remove this: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L207

I found hardcoded port here: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L79

I find it suspicious that we resolve our promise here: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L147

we don't guarantee that task will be sent in the same order (because we just place task to the scheduler, but don't know when scheduler will take it): https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L163 .. and we don't await this send function promise

jonyrock avatar Jul 12 '20 20:07 jonyrock