bashio icon indicating copy to clipboard operation
bashio copied to clipboard

Published 20 hours ago • verified publisher icon hassio-addons

Allow multiple lines in var.json

Open felipecrs opened this issue 2 years ago • 13 comments

Proposed Changes

  • Allow new lines to be used in values for the var.json
  • Properly escape all characters for a proper JSON string, not only line breaks
  • Fix issue when ^ character would be used in a key and the key would evaluated as key rather than "^key" leading to a non-valid JSON
  • Introduces a function ``var.json_string` which escapes a Bash string for use in a JSON object

Related Issues

Fixes #94

felipecrs avatar Mar 07 '22 12:03 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Apr 07 '22 08:04 github-actions[bot]

I think this still deserves some attention. :)

felipecrs avatar Apr 07 '22 16:04 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar May 12 '22 08:05 github-actions[bot]

This is not stale

felipecrs avatar May 12 '22 13:05 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jun 13 '22 08:06 github-actions[bot]

Not stale, ready for review.

felipecrs avatar Jun 13 '22 15:06 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jul 15 '22 08:07 github-actions[bot]

(I tested it, if that counts)

felipecrs avatar Jul 15 '22 11:07 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 15 '22 08:08 github-actions[bot]

Not stale...

felipecrs avatar Aug 15 '22 11:08 felipecrs

LGTM, I have to test it

@pvizeli any updates on the review of this PR?

brenner-tobias avatar Sep 14 '22 15:09 brenner-tobias

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Oct 15 '22 08:10 github-actions[bot]

Not stale

felipecrs avatar Oct 15 '22 15:10 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 16 '22 08:11 github-actions[bot]

This is not stale, only pending review and merge?

felipecrs avatar Nov 16 '22 13:11 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Dec 18 '22 08:12 github-actions[bot]

Is there a way to tell the stale-bot to ignore this PR?

felipecrs avatar Dec 18 '22 16:12 felipecrs

@pvizeli any chance to have a look at this?

brenner-tobias avatar Jan 13 '23 22:01 brenner-tobias

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Feb 13 '23 08:02 github-actions[bot]

Not stale.

felipecrs avatar Feb 13 '23 11:02 felipecrs

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Mar 17 '23 08:03 github-actions[bot]

:(

felipecrs avatar Mar 17 '23 11:03 felipecrs

@pvizeli will there be any review / feedback on this or should we give up and close this?

brenner-tobias avatar Apr 08 '23 13:04 brenner-tobias

@pvizeli can this change be merged please?

falzm avatar Apr 10 '23 13:04 falzm

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar May 11 '23 08:05 github-actions[bot]

You have access right @pvizeli :)

Feel free to merge and handle as such if you are ok with it 👍

frenck avatar May 11 '23 14:05 frenck

@frenck your feedback would also be appreciated nevertheless :)

felipecrs avatar May 11 '23 15:05 felipecrs