addon-spotify-connect icon indicating copy to clipboard operation
addon-spotify-connect copied to clipboard

Add `initial_volume` option

Open DarkMatterMatt opened this issue 1 year ago • 4 comments

This PR adds support for changing the default volume. It's completely opt-in and does not change any existing behaviour

Currently the default is at 90% volume. While I appreciate my speakers' ability to be loud, I wanted to be able to default to a more sensible volume.

See the librespot documentation for more information on how initial-volume works


To test this option:

  1. Change the value in the config, e.g. 50 (50%)
  2. Save changes & restart the addon a. If the log level is debug, see that initial-volume is present in the Command line argument(s) section
  3. Connect to Home Assistant from another device, see that the volume is 50%

DarkMatterMatt avatar Apr 06 '24 12:04 DarkMatterMatt

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar May 07 '24 08:05 github-actions[bot]

.

DarkMatterMatt avatar May 07 '24 23:05 DarkMatterMatt

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jun 07 '24 08:06 github-actions[bot]

.

DarkMatterMatt avatar Jun 10 '24 23:06 DarkMatterMatt

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jul 12 '24 08:07 github-actions[bot]

Walkthrough

The recent update introduces a new configuration option, initial_volume, to the HomeAssistant integration with Spotify. This option allows users to set the initial volume level (0-100%) for Spotifyd. Changes include modifications to documentation, configuration schema, service run script, and translations to support this new feature.

Changes

Files Change Summary
spotify/DOCS.md Added documentation for the new initial_volume option.
spotify/config.yaml Introduced initial_volume field in the configuration schema.
spotify/rootfs/.../spotifyd/run Implemented logic to set initial volume for Spotifyd.
spotify/translations/en.yaml Added translations for initial_volume setting.

Poem

In the land of tunes and beats so grand,
A volume control now at your command.
Set it high or keep it low,
Your Spotifyd will always know.
A tweak, a change, a simple script,
To make your music sound just right, off the clip! 🎵


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 12 '24 08:07 coderabbitai[bot]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 12 '24 08:08 github-actions[bot]