Rewrite to support IPv6 Link Local addresses

[erwin-willems]

Proposed Changes

IPv6 Link Local Addresses (fe80) were skipped during the configuration of the interface binding. A use case could be to run your DNS server on address fe80::53 on all your networks. For this LLA should be supported.

For LLA binding, the interface name needs to be added to the binding. Like: fe80::53%enp1s0. I've rewritten the script to parse LLA with interface bindings.

This PR can be tested on my Dev repository: https://github.com/erwin-willems/hassio-addons

Related Issues

#463 adguarhome add-on does not listen on ipv6 link-local address, and zerotier interface

[erwin-willems]

@frenck What is needed to get this one merged? (or closed with comment, which is also fine of course)

[LordNex]

You might want to add the ability of which VLAN Interface you want it to listen on. I have a bug report out there now because I have a miltisubnetted network Main/IoT/Guest, that way all my IoT traffic doesn't interfere with my other device and such. Currently there is no standard way to define which interface it will pick as it's “default” interface. I'm running IPV6 on all my subnets as well. Not as important there but it still seem to cause issues from time to time. See 84113

[osh123]

any chance of this being merged? ipv6 is unusable without this :|

[danielszilagyi]

any chance of this being merged? ipv6 is unusable without this :|

Great that I found this before forking the official repo. I think the test output should be checked and the labels adjusted at least to get this merged. Actually, I just wanted to get away with being able to configure locServedNets (https://github.com/AdguardTeam/AdGuardHome/issues/3142) from the addon config but seems this PR is about a different IPv6 related issue.

[osh123]

Until we get a fix, I used socat to redirect traffic from fe80:: IP to the IPv4 one:

socat -T 1 UDP6-LISTEN:53,fork,reuseaddr,bind=[$IPV6%$IPV6_INTERFACE] UDP4:$IPV4

Just replace $IPV6 with the fe80 address, $IPV6_INTERFACE with the network interface (in my case it was enp2s0) and $IPV4 with the IPv4 address.

I've set it up as service:

[Unit]
Description=Forwards ipv6 link-local udp port 53 to IPv4 udp

[Service]
Type=simple


ExecStart=-/usr/bin/socat -T 1 UDP6-LISTEN:53,fork,reuseaddr,bind=[$IPV6%%$IPV6_INTERFACE] UDP4:$IPV4
ExecStop=-/usr/bin/killall socat
Restart=on-failure
RestartSec=1s

[Install]
WantedBy=multi-user.target

it's not the best solution, but its working for me for the past few days.

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[snapsl]

Tested and it works. Can this PR be merged so everyone can use this?

[Amit-Shan]

Thumbs up for this PR. Hopefully, it can be merged soon.

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[jenschude]

Is there a possibility to get this approved? I get a new IPv6 address assigned on reconnect of the Internet and then all network devices also get new addresses. Listening to the link local address would provide a stable address for home network devices.

[snapsl]

@frenck pls, review.

[erwin-willems]

Just updated / rebased this PR. You can test / use this fix via https://github.com/erwin-willems/hassio-addons

[jenschude]

@erwin-willems can you add a label like enhancement ? The CI build fails atm due to a missing label in the PR

[erwin-willems]

I don't know how to add labels. Have the feeling that I don't have permission for that

[Amit-Shan]

I don't know how to add labels. Have the feeling that I don't have permission for that

It seems like someone else added the label. Now, it says all checks have passed. I assume this means that @frenck just needs to authorize the commit after reviewing it. Fingers crossed no other issues show up.

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[Amit-Shan]

Not stale.

[frenck]

@coderabbitai review

[coderabbitai[bot]]

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai[bot]]

Walkthrough

The update to the init-adguard/run script focuses on refining IP address management. It now adeptly handles IPv4 and IPv6 addresses from interfaces, eliminates netmasks, and incorporates addon and localhost IP addresses for enhanced network functionality.

Changes

Files	Change Summary
adguard/rootfs/.../init-adguard/run	Updated IP address handling to manage IPv4 and IPv6 addresses, exclude netmasks, and add addon and localhost IPs.

🐇 In scripts where data flows so free, New IPs dance with IPv4 and IPv6 glee, Addon and localhost join the spree, Binding together in harmony, A network symphony, for all to see. 🌐✨

[!TIP]

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

• Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
• Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
• Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

• Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
• Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
• High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
• Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.