ADotNet icon indicating copy to clipboard operation
ADotNet copied to clipboard

FOUNDATIONS: Check PR Title Job

Open cjdutoit opened this issue 1 year ago • 3 comments

This job will checkout that a PR has been created with one of THE STANDARD accepted categories mentioned here: https://github.com/hassanhabib/The-Standard-Team/blob/main/4%20Practices/4%20Practices.md#4113-category-list

                Jobs = new Dictionary<string, Job>
                {
                    {
                        "check_pr_title",
                        new CheckPrTitleJob(
                            runsOn: BuildMachines.UbuntuLatest)
                    },
                    {
                        "build",
                        new Job
                        {
                            Needs = new string[] { "check_pr_title" },
                            . . . 
                        }
                    }
                }

STEPS:

  • Add the "check_pr_title" job before existing jobs
  • Optionally add Needs = new string[] { "check_pr_title" }, to the job after this one, this will stop processing of subsequent jobs on fail.

Sample success message image

image

Sample error message image

cjdutoit avatar Dec 27 '23 17:12 cjdutoit

@elbekdeveloper is this a toaster?

hassanhabib avatar Jan 06 '24 03:01 hassanhabib

@hassanhabib, @cjdutoit, @ElbekDeveloper Docs need to align, when branch naming we use a mix of singularity and plurals, when naming a pull request here(see pr commits), we appear to be using only singular category names. It becomes hard to assist new comers to The Standard when these mixed signals are out there.

image

image

glhays avatar Jan 07 '24 20:01 glhays

@hassanhabib, @cjdutoit, @ElbekDeveloper Docs need to align, when branch naming we use a mix of singularity and plurals, when naming a pull request here(see pr commits), we appear to be using only singular category names. It becomes hard to assist new comers to The Standard when these mixed signals are out there.

image

image

Hi @glhays / @hassanhabib / @ElbekDeveloper, this was done on purpose to closely match GitFyle, but happy to change this to plural version only as long as that is supported by GitFyle.

cjdutoit avatar Jan 19 '24 17:01 cjdutoit