sclack icon indicating copy to clipboard operation
sclack copied to clipboard

Support notification

Open duynguyenhoang opened this issue 6 years ago • 6 comments

Hi @haskellcamargo, it would be nice to have the notification.

I am working on it to support notification, the first version will be supported for MacOS only.

duynguyenhoang avatar Aug 09 '18 09:08 duynguyenhoang

Cool! For Linux, after your PR, we can be working with an integration with libnotify (for Windows I still have no idea, by the way). Thank you for your effort!

haskellcamargo avatar Aug 09 '18 12:08 haskellcamargo

@duynguyenhoang whats the update on this? In case you need help please let me know.

infinite-Joy9l avatar Aug 14 '18 05:08 infinite-Joy9l

Hi @infinite-Joy9l
It would be nice if you can use below branch to check notification feature

https://github.com/duynguyenhoang/sclack/tree/feature/add_notification

This branch supported both MacOS and Linux (tested with Fedora)

duynguyenhoang avatar Aug 14 '18 05:08 duynguyenhoang

@duynguyenhoang I've just invited you to have write access to this repository. I'm very grateful for the work you are doing on this. Thank you!

haskellcamargo avatar Aug 14 '18 14:08 haskellcamargo

@duynguyenhoang do you know a good way to test this. I am facing issues where the conversations are not updating as well and hence not sure if the notifications are working or not.

infinite-Joy9l avatar Aug 15 '18 04:08 infinite-Joy9l

@infinite-Joy9l I am able to receive new messages, Could you please try it again?

Seem the problem with receiving new messages only occur in some cases. I am going to check it as soon as possible.

duynguyenhoang avatar Aug 15 '18 04:08 duynguyenhoang