vscode-haskell icon indicating copy to clipboard operation
vscode-haskell copied to clipboard

hls-class-plugin setting fields are missing

Open July541 opened this issue 2 years ago • 4 comments

After https://github.com/haskell/haskell-language-server/pull/2920, hls-class-plugin has two configurable fields now(after https://github.com/haskell/haskell-language-server/pull/3107), including:

  1. haskell.plugin.class.codeActionsOn
  2. haskell.plugin.class.codeLensOn

But currently vscode-haskell only has the first one.

July541 avatar Aug 15 '22 13:08 July541

Weird, must have slipped through :(

fendor avatar Aug 15 '22 13:08 fendor

My fault, I should raise an issue here after https://github.com/haskell/haskell-language-server/pull/2920. But the pr takes so much time, I forgot it...

July541 avatar Aug 15 '22 13:08 July541

BTW, will you update the fields by scanning the pr list in hls or rely on haskell-language-server generate-default-config?

July541 avatar Aug 15 '22 14:08 July541

I rely on haskell-language-server vscode-extension-schema which I copy-paste into package.json. More automation would be welcome, so far I couldn't find any existing infrastructure for doing it automatically.

However, I am currently working on printing the json with sorted keys, making sure we haven't deleted anything on accident and making it easier to view added keys.

fendor avatar Aug 15 '22 14:08 fendor

I think this will be fixed in #773, @July541 could you make sure the current version of package.json contains all the hls-class-plugin options it should contain?

fendor avatar Dec 05 '22 09:12 fendor

Looks reasonable to me, and I confirmed

{
    "haskell.plugin.class.codeLensOn": false,
    "haskell.plugin.class.codeActionsOn": false
}

works for me.

Let's go!

July541 avatar Dec 05 '22 14:12 July541