text icon indicating copy to clipboard operation
text copied to clipboard

t_toUpper_char fails on s390x

Open Bodigrim opened this issue 1 year ago • 3 comments

https://github.com/haskell/text/actions/runs/9628836664/job/26557513845 failed with

             t_toUpper_char:                            FAIL (0.02s)
              *** Failed! Falsified (after 80 tests):
              '\42954'
              "\42953" /= "\42954"
              Use --quickcheck-replay=567863 to reproduce.

I have not looked into it, just filing.

Bodigrim avatar Jun 22 '24 23:06 Bodigrim

The failing test t_toUpper_char is guarded by a MIN_VERSION_base(...) condition which goes out of date almost every time we upgrade the Unicode version for the case mappings in text.

  • GHC 8.8/base 4.13 (what is available in the s390x runner) uses Unicode 12.0
  • Those two characters in the failing test case are from Unicode 13.0
  • (for the record, text is currently at Unicode 15.0)

Lysxia avatar Jul 01 '24 10:07 Lysxia

Related: haskell/core-libraries-committee#278

wismill avatar Jul 22 '24 18:07 wismill

This is now kinda fixed because the s390x runner updated from GHC 8.8 to GHC 9.4.

Bodigrim avatar Oct 20 '24 21:10 Bodigrim