Fixed off by one for writeBlocksRaw

[BebeSparkelSparkel]

closes #587

[Bodigrim]

Is it possible to add a regression test?

[BebeSparkelSparkel]

It may be possible, but I am unsure how to. This is a case of the last character in the buffer not being used because the bounds check was copy pasted from the above write* functions that have the possibility of writing two characters CRLF.

[Bodigrim]

Would anything in the current test suite break if we put n - 10 instead of n / n + 1? Do we have any tests in this area at all?

[BebeSparkelSparkel]

All tests pass with n - 10

[BebeSparkelSparkel]

I don't know how to test for buffer overflow unless we can add a test buffer type that checks for that.

[Lysxia]

We might not catch this in regular builds but we can test this by inserting a debug assertion (enabled by -DASSERTS under the -fdeveloper cabal flag) to ensure that writeCharBuf is within bounds.

[BebeSparkelSparkel]

@Lysxia Good idea. I have added the bounds assertion to a wrapped writeCharBuf

[BebeSparkelSparkel]

@Bodigrim Anything else that needs to be done?

[Bodigrim]

Thanks!