stm icon indicating copy to clipboard operation
stm copied to clipboard

Update tests for CLC proposal: Modify displayed exception type

Open tbidne opened this issue 1 year ago • 1 comments

Now that the CLC proposal has been approved, this can be merged.

https://github.com/haskell/core-libraries-committee/issues/261.

See https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12242.

Obviates https://github.com/haskell/stm/pull/81.

tbidne avatar Jul 04 '24 22:07 tbidne

CI is currently failing due to a glibc mismatch:

2024-07-04T22:29:26.2172453Z Processing triggers for libc-bin (2.27-3ubuntu1.6) ...
...
2024-07-04T22:30:43.8257620Z /__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

2.27 (and 2.28, for that matter) are quite old, and so is the ubuntu runner 20.04 (ubuntu-latest is 22.04). Perhaps this should be updated?


Edit: Updating the runner (or checkout to v4) does not help, see: https://github.com/haskell-CI/haskell-ci/issues/738.

tbidne avatar Jul 05 '24 00:07 tbidne

Create cabal.haskell-ci and override the container distribution manually:

distribution: jammy

We had to do this with some of our packages, too: https://github.com/bellroy/unliftio-servant-server/blob/c91cd898561c142fa382ccf2e045552d0dd27173/cabal.haskell-ci

JackKelly-Bellroy avatar Jul 12 '24 21:07 JackKelly-Bellroy

Thanks! PR incoming.

tbidne avatar Jul 14 '24 04:07 tbidne

@wz1000 now that CI is passing, might you be able to merge this one?

tbidne avatar Jul 23 '24 21:07 tbidne

@wz1000 @andreasabel does anyone of you feel comfortable to merge? The CLC proposal has been approved a month ago, so I don't think the change of baseline is controversial.

Bodigrim avatar Jul 31 '24 21:07 Bodigrim

Well, I could merge it, but I could not retrieve evidence of its correctness:

The affected test case stm055 is not contained in the cabal-runnable testsuite testsuite/. Instead it is contained in the older tests/ suite that is not covered by CI. Trying to run it manually I get the following output:

stm/tests[master]$ ./runtests.sh 
using GHC version: 9.10.1
== running test 'T15136'
Loaded package environment from /Users/abel/bin/src/stm/.ghc.environment.x86_64-darwin-9.10.1
[1 of 2] Compiling Main             ( T15136.hs, T15136.o )
[2 of 2] Linking T15136
validate stdout output...
--- T15136.stdout	2024-04-13 10:30:37.000000000 +0200
+++ T15136.stdout.run	2024-08-01 07:44:55.000000000 +0200
@@ -1 +0,0 @@
-1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 
\ No newline at end of file

To me it looks like one or more tests are in a broken state and I do not even get to see the result of test stm055.

andreasabel avatar Aug 01 '24 05:08 andreasabel

If you update https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12242 to point to the same commit (e9e9aaa8f625143f197cf44b03971ee850d1455e) and the GHC CI passes, I think we can merge this.

wz1000 avatar Aug 01 '24 07:08 wz1000

MR has been updated to the current commit here and CI passing.

tbidne avatar Aug 01 '24 12:08 tbidne

Thanks @wz1000!

tbidne avatar Aug 01 '24 13:08 tbidne