process icon indicating copy to clipboard operation
process copied to clipboard

Posix: Do not treat arguments as `FilePath`

Open mmhat opened this issue 1 year ago • 2 comments

Fixes #319

mmhat avatar Jun 22 '24 12:06 mmhat

This looks pretty plausible to me, but I'm not an expert with the low level details. There are various people who are better qualified. Perhaps one of them can chime in.

@bgamari @hasufell @snoyberg @Mistuke (or someone else?)

tomjaguarpaw avatar Jul 23 '24 14:07 tomjaguarpaw

There are two differences:

  1. withFilePath uses getFileSystemEncoding, withCString uses getForeignEncoding
  2. withFilePath checks for interior nulls now (not sure since which base version) and barfs out in case it finds any

Tbh, all of those s*ck. But that's another discussion: https://github.com/haskell/process/issues/252

hasufell avatar Jul 23 '24 14:07 hasufell

  1. withFilePath checks for interior nulls now (not sure since which base version) and barfs out in case it finds any

I think it is since base-4.18.0.0 (GHC 9.6.1).

If there are no further objections: Who is willing to merge this?

mmhat avatar Aug 09 '24 20:08 mmhat

OK, released as https://hackage.haskell.org/package/process-1.6.22.0. Thanks @mmhat!

tomjaguarpaw avatar Aug 16 '24 06:08 tomjaguarpaw