hie-bios icon indicating copy to clipboard operation
hie-bios copied to clipboard

configurable verbosity

Open teto opened this issue 3 years ago • 2 comments

some of the changes are just recommandations made by haskell-language-server, I saw it fit to make hie-bios follows the recommandation from the software it exists for.

I would like to make this change configurable on the CLI rather than hardcode it https://github.com/mpickering/hie-bios/compare/master...teto:nix?expand=1#diff-268e4205229d03a6419924ecdf57a963794db10db21703878f4d22424f2c8b58R47
Do you think its a good idea ? or maybe we could just remove the setVerbosity 0 -- Set verbosity to zero just in case the user specified -vx in the options. ? The user can set -v0 himself ? and is there any reason not to show a detailed log in the first place ?

teto avatar Jan 11 '21 10:01 teto

Please avoid unnecessary changes unless there is a real benefit. We do not follow hlint guidelines, so although this project is a foundation for hls, there is no reason to follow rules of some plugin, just because they are the default. (E.g., hie-bios existed when hls did not even have a hlint plugin)

fendor avatar Jan 11 '21 20:01 fendor

sure for the hlint changes, gonna drop. Now I wonder about how to enable a more verbose hie-bios: should I: 1/ just disable the automatic verbisotiy0 to let a cradle's -v2 succeed 2/ just let the user pass some arbitrary args that override a default -v0 3/ add an arugment hie-bios --verbosity=1

I assume we want the feature (I found it very helpful).

teto avatar Jan 11 '21 22:01 teto

I haven't needed to dig deeper as haskell-language-server improves, thus closing

teto avatar Jun 13 '23 13:06 teto