haskell-mode icon indicating copy to clipboard operation
haskell-mode copied to clipboard

Run hooks for haskell-error-mode

Open erickgnavar opened this issue 3 years ago • 3 comments

When haskell-interactive-popup-error is called, haskell-error-mode hooks aren't running because run-hooks call is missed

erickgnavar avatar Apr 24 '21 17:04 erickgnavar

Isn't this because the hook variable name produced by the define-minor-mode form is haskell-error-mode-hook, without a trailing s?

purcell avatar Apr 25 '21 00:04 purcell

Isn't this because the hook variable name produced by the define-minor-mode form is haskell-error-mode-hook, without a trailing s?

The code I'm adding is without the trailing s as you can see

(run-hooks 'haskell-error-mode-hook)

Maybe there was a confusion with the PR's description 🤔

erickgnavar avatar Apr 25 '21 13:04 erickgnavar

Oh, sorry if I got confused. But in any case, the expanded definition of haskell-error-mode includes code to run that hook, so I'd like to understand why that didn't seem to be working for you.

purcell avatar Apr 25 '21 22:04 purcell