haskell-language-server icon indicating copy to clipboard operation
haskell-language-server copied to clipboard
verified publisher icon haskell

4718 hls graph session restart kills threads belong to later sesion session

Open soulomoon opened this issue 4 months ago • 2 comments

WordAround #4718

Fix the two problems that make hlint plugin flaky

  1. uninterruptibleMask_ to avoid argsSettings capture async exception
  2. bracket around runWithSignal to avoid sending the start signal without end signal, which would make hlint's tests flasky

soulomoon avatar Aug 31 '25 20:08 soulomoon

I just found this again, is this ready for merge? At least the bracket_ seems like an improvement for the tests.

fendor avatar Nov 24 '25 17:11 fendor

I just found this again, is this ready for merge? At least the bracket_ seems like an improvement for the tests.

Thanks for digging it up.

This patch is not enough. and I traced it down, one of the thing we still need to do is that we should wait for the debouncer before we send the done signal.

soulomoon avatar Nov 24 '25 21:11 soulomoon