haskell-language-server icon indicating copy to clipboard operation
haskell-language-server copied to clipboard
verified publisher icon haskell

Release 2.10.0.0

Open fendor opened this issue 1 year ago • 1 comments

Since GHC 9.8.3 has been published on the 20.10.2024, we need to do an HLS release to support the new GHC version.

Unless I am mistaken, the new release should be for the following GHC versions:

  • 9.4.8
  • 9.6.6
  • 9.8.3
  • 9.10.1

In particular, we dropped support for GHC 9.2 in #4326

fendor avatar Oct 21 '24 13:10 fendor

I can take care of the release in the near future.

Before the release, we want to merge #4392

fendor avatar Oct 21 '24 13:10 fendor

@hasufell Pinging you so you know we are planning a release soon :tm:

fendor avatar Oct 22 '24 11:10 fendor

I would really appreciate it if we could also get https://github.com/haskell/haskell-language-server/pull/4433 in.

noughtmare avatar Oct 24 '24 20:10 noughtmare

Merging #4433 just before the release is quite risky as there is no time to do any dogfooding. So I don't think we will wait for it if we don't manage to get enough reviews. I pinged a couple of potential reviewers, so perhaps. As GHC 9.12 is planned to be released in November, there will be another HLS release soon after 2.10.0.0.

fendor avatar Oct 25 '24 07:10 fendor

Has building with 9.8.3 been tested?: 2.9 fails for me with:

src/Development/IDE/GHC/Compat/Core.hs:712:10: error: [GHC-83865]
    ・ Couldn't match expected type: Maybe String
                  with actual type: Either
                                      String
                                      (ghci-9.8.3:GHCi.RemoteTypes.RemotePtr
                                         ghci-9.8.3:GHCi.Message.LoadedDLL)
    ・ In the first argument of ’pure‘, namely ’res’
      In a stmt of a 'do' block: pure res
      In the expression:
        do res <- GHCi.loadDLL (hscInterp env) str
           pure res
    |
712 |     pure res
    |          ^^^

I should better file an issue I guess - I see in git it is currently conditional on ghc >= 9.11

CI still seems to be using 9.8.2.

juhp avatar Oct 28 '24 06:10 juhp

I should better file an issue I guess

@juhp No. Wait for 2.10.0.0.

benz0li avatar Oct 28 '24 06:10 benz0li

The latest Stackage LTS, 23.x, is for GHC 9.8.4. Any chance we can skip 9.8.3 and go straight to 9.8.4?

sjshuck avatar Dec 30 '24 00:12 sjshuck

Regarding GHC 9.12.2:

  • https://github.com/haskell/haskell-language-server/issues/4499

benz0li avatar Mar 15 '25 17:03 benz0li

@fendor This may be closed now.

benz0li avatar Mar 30 '25 18:03 benz0li