haskell-language-server icon indicating copy to clipboard operation
haskell-language-server copied to clipboard

hls-cabal-plugin: refactor context search to use `readFields`

Open fendor opened this issue 1 year ago • 4 comments

Replace the more brittle parser with cabal's readFields.

Ready for review :)

fendor avatar Apr 21 '24 12:04 fendor

Why is the test not running

soulomoon avatar May 28 '24 06:05 soulomoon

Hm, I am also confused. Perhaps all my force pushing messed up the CI :)

fendor avatar May 28 '24 07:05 fendor

Will it help with https://github.com/haskell/haskell-language-server/issues/3333

soulomoon avatar May 28 '24 07:05 soulomoon

No, this tries to fix some bugs in the cabal file completions that I encountered while dogfooding the plugin. This does not affect the tests at all.

The tests are flaky, for the same reason hlint tests are/were flaky, afaict.

fendor avatar May 28 '24 07:05 fendor