haskell-language-server icon indicating copy to clipboard operation
haskell-language-server copied to clipboard

Speed up hls-hlint-plugin-tests

Open fendor opened this issue 1 year ago • 2 comments

Migrate hls-hlint-plugin-tests to use VirtualFileTree infrastructure for test data. Avoid waitForDiagnosticsWithSource which makes the test wait for 5 seconds, even though it might have received the diagnostics already.

fendor avatar Mar 19 '24 18:03 fendor

This doesn't quite work yet, as the test asserts sometimes that no diagnostic is emitted from the very beginning. However, on initial load, HLS doesn't publish empty diagnostics, so we don't know when processing finished. We probably need to insert some dummy diagnostics, and clear them.

fendor avatar Mar 19 '24 18:03 fendor

Tests are much quicker now, 15 seconds instead of 2 minutes! Just not sure how to refactor this to make it reusable :sweat_smile:

fendor avatar Mar 22 '24 15:03 fendor

Closing in favour of #4339

fendor avatar Jul 13 '24 15:07 fendor