haskell-language-server icon indicating copy to clipboard operation
haskell-language-server copied to clipboard
verified publisher icon haskell

HLS source distribution is missing extra-source-files necessary for testing

Open fendor opened this issue 1 year ago • 3 comments

image

Vs:

> ls plugins/hls-semantic-tokens-plugin/test/testdata/ | wc -l
52

In particular, we are missing all *.expected files. We should test that we can run the tests of the source distribution produced by cabal sdist.

fendor avatar Feb 29 '24 12:02 fendor

Closed by #4105

fendor avatar Feb 29 '24 13:02 fendor

We fixed this situation in #4105 and #4107, but we should add a CI check that this can't happen again. Potentially, the workflow for running tests should be as follows: cabal sdist > tar > cabal test. Iirc, haskell-ci generates this workflow.

fendor avatar Mar 03 '24 10:03 fendor

Relevant: https://github.com/haskell/cabal/issues/1141

michaelpj avatar Apr 24 '24 09:04 michaelpj