haskell-language-server icon indicating copy to clipboard operation
haskell-language-server copied to clipboard

Fix renaming data constructors with fields (resolves #2915, resolves #4083)

Open jhrcek opened this issue 1 year ago • 1 comments

This only works for renaming across single file. To make the multi-file scenario work, we'll need something like https://github.com/wz1000/HieDb/pull/73

jhrcek avatar Feb 21 '24 04:02 jhrcek

I'm turning this back to draft, because @michaelpj pointed out that ignoring GeneratedInfo in HieAST could lead to some issue down the line (where we ignore something that shouldn't be ignored) and he proposed an alternative approach to avoiding renaming things that should not be renamed: namely validating that each Range being renamed actually contains the Text corresponding to the old name.

jhrcek avatar Mar 02 '24 16:03 jhrcek