Add option to disable import popup notification

[scarf005]

Is your feature request related to a problem? Please describe.

Everytime I auto-import, a notification pops up. I have to remove it manually using ESC, and it's quite tedius.

Describe the solution you'd like

Add an extension option to disable import popup notification.

Describe alternatives you've considered tried to find an option to turn this off in extension settings but couldn't find any

Additional context

notification in question

[fendor]

Hi, thank you for your bug-report! I think we need to move this issue to HLS main repo, as this message is sent from it... Unless we can filter it in the client somehow. Moving issue, s.t. we have more eyes on it.

[michaelpj]

I'm a bit confused about where this is coming from? Any vscode users who can see from the logs what's causing this?

[fendor]

Hm, maybe it is indeed a built-in feature from vscode?

[fendor]

Presumably, it comes from here: https://github.com/haskell/haskell-language-server/blob/master/plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs#L202

[michaelpj]

Looks like it's been there for a long time, introduced here: https://github.com/haskell/haskell-language-server/pull/1371

Apparently I objected to it then, and I still do :D We could use AnnotatedTextEdits now, I think.

[pepeiborra]

Presumably AnnotatedTextEdits would make an HLS option to disable them unnecessary, since the client would be responsible for that right?

[michaelpj]

I think so, but I haven't actually tested what they look like in clients.

[michaelpj]

Semantically, it's the right thing from the spec's perspective, I think.

[michaelpj]

I made an issue for using them more widely: https://github.com/haskell/haskell-language-server/issues/3210