haskell-language-server
haskell-language-server copied to clipboard
upgrade lsp to 1.5
I'm receiving a lot of logs like this if --verbose
is enabled in ghcide-tests
. And finally got OOM even with 64GB memory.
So disabling it for now
I see. In lsp
, there is a debug log, printing response body:
https://github.com/haskell/lsp/blob/8b63438313828a31ba1065ea865e504d532d093e/lsp/src/Language/LSP/Server/Control.hs#L224-L234
And in HLS, our logger sends a copy of log to LSP client:
https://github.com/haskell/haskell-language-server/blob/347a7187f20242540926b9927c59a45b18798c67/exe/Main.hs#L72-L82
Then it goes into infinite recursion... So we should not enable debug logs in lsp
package itself.
Hmm, I thought I had convinced myself that wasn't a problem :| I'm not 100% sure what to do about this. It's nice to be able to log the responses from LSP, but we do indeed have a loop problem if we then forward them on like this.
It's nice to be able to log the responses from LSP
And some other tests depend on the logs, I had to fix them one by one. This makes the PR harder than I initially thought.
Currently I'm working on hlint tests
Finally, the CI is almost green.