haskell-ide-engine icon indicating copy to clipboard operation
haskell-ide-engine copied to clipboard

Put IdeResult in terms of Either, add ideError

Open Gurkenglas opened this issue 4 years ago • 3 comments

Let's try this again.

Gurkenglas avatar Jan 27 '20 22:01 Gurkenglas

@Gurkenglas What is the motive for this change? It is allot more concise.

Avi-D-coder avatar Jan 27 '20 23:01 Avi-D-coder

You have answered your question :3

Gurkenglas avatar Jan 28 '20 00:01 Gurkenglas

Thanks for the pr, i think the intent is good and i always like the prs that remove locs (the actual new type has its own advantages though). However, as you surely already knows, we just have start a process of integration with ghcide so it is the actual main focus. We will continue to fix bugs but we will prefer that the new code or internal refactorings go in that direction (see https://github.com/haskell/haskell-ide-engine/issues/1416#issuecomment-579010923).

jneira avatar Jan 28 '20 00:01 jneira