haddock icon indicating copy to clipboard operation
haddock copied to clipboard

New theme scrolls horizontally.

Open phadej opened this issue 6 years ago • 7 comments

On my machne http://hackage.haskell.org/package/sop-core-0.4.0.0/docs/Data-SOP.html has horizontal scroll bar

Seems big instances overflow:

screenshot from 2019-02-28 15-38-30

phadej avatar Feb 28 '19 13:02 phadej

This is particularly bad, e.g. in servant-server:

screenshot from 2019-02-28 15-53-18

phadej avatar Feb 28 '19 13:02 phadej

This isn't something specific to the new theme, but I agree completely: the display of instances is pretty terrible (with the huge lines due to long instance heads, then the huge vertical space due to instance docs).

harpocrates avatar Feb 28 '19 14:02 harpocrates

@harpocrates, it is specific. See e.g.

http://hackage.haskell.org/package/servant-server-0.16/docs/Servant-Server-Internal.html

The layout is not nie, but at least the page doesn't scroll horizontally, <--->.

screenshot from 2019-02-28 16-40-40

phadej avatar Feb 28 '19 14:02 phadej

Oh nice catch! Will fix ASAP. Thanks for sticking to your guns, and pasting in the old output.

harpocrates avatar Feb 28 '19 15:02 harpocrates

This seems to be part of the issue: https://github.com/haskell/haddock/blob/59843f9e3d222901421a92fff793a1e031f38f65/haddock-api/resources/html/Linuwial.std-theme/linuwial.css#L564-L566

Would you be OK if this got punted over to the next release (8.8.2 in this case)? I've never been too happy about the placement of docs in large instances. The new theme really exacerbates the problem (by forcing a narrower width), but fixing this properly is gonna involve a bit more time than is left...

harpocrates avatar Feb 28 '19 16:02 harpocrates

I know this is almost 18 months old now, but I would like to bring attention to it once more as this issue is still present :(

hhhapz avatar Jul 25 '20 06:07 hhhapz

On android chrome this is a pretty large issue because you can't scroll any of the reasonably sized code examples unless you zoom all the way out. For example, I have to zoom out to the attached screenshot so I can scroll the code sample, then zoom back in to actually read it. Screenshot_20240116_212658_Chrome

jhgarner avatar Jan 17 '24 05:01 jhgarner

This ticket now lives at https://gitlab.haskell.org/ghc/ghc/-/issues/24729

Kleidukos avatar May 22 '24 12:05 Kleidukos