hackage-server icon indicating copy to clipboard operation
hackage-server copied to clipboard

Builder for candidates still needs work

Open gbaz opened this issue 4 years ago • 1 comments

These lines screw things up:

https://github.com/haskell/hackage-server/blob/4d6d2089d442859e3d04874a82f421cb8950eef5/exes/BuildClient.hs#L496

https://github.com/haskell/hackage-server/blob/4d6d2089d442859e3d04874a82f421cb8950eef5/exes/BuildClient.hs#L499

This looks up the package in the repoIndex. But for a candidate that isn't a dup (i.e. for which that name/version pair is not yet in the main index) then of course the package won't be in the repoIndex yet!

So we need a different code path for candidates that entirely bypasses these lookups and handles candidates specially/directly.

gbaz avatar Jul 06 '21 22:07 gbaz

Also we should bypass builds for candidates with versions already in the main index...

gbaz avatar Jul 28 '21 17:07 gbaz